[collectd] quick and dirty patch

Florian Forster octo at verplant.org
Tue Mar 4 15:54:32 CET 2008


Hi Łukasz,

On Tue, Mar 04, 2008 at 02:58:14PM +0100, Łukasz Mierzwa wrote:
> [...] I made this quick patch so collectd will create only one cpu
> graph.

I understand that putting all these files into one graph for all CPUs is
a lot of work and I don't have code that does that either. But I can't
accept the patch as it is, because it'd break backwards compatibility.

If you add a option, such as
  MergedCPUs <no>|<only>|<both>
where
  `no'   means: don't combine CPUs (default)
  `only' means: collect only the combined data
  `both' means: collect the combined data in addition to the per-CPU
                data
this would not break backwards compatibility and I could add it to the
daemon.

> Also would it be possible to implement DERIVE to data types? Now it's
> only counter and gauge.

Sure, shouldn't be too hard to implement. You'd have to touch numerous
places, though. To find them, I'd use something like:
  $ grep -l 'DS_TYPE_COUNTER\|DS_TYPE_GAUGE' src/*.c

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20080304/0d4a6d37/attachment.pgp 


More information about the collectd mailing list