[collectd] utils_dns patch

Florian Forster octo at verplant.org
Sat Jun 7 20:22:58 CEST 2008


Hi Oleg,

On Wed, Jun 04, 2008 at 06:36:28PM +0400, Oleg King wrote:
> On old FreeBSD T_TSIG is not defined in
> /usr/include/arpa/nameser_compat.h (see mantis, issue #21).
> This patch will resolve this problem.

> +#ifndef T_TSIG
> +# define T_TSIG 250
> +#endif

where is that 250 coming from? On my Debian machine it's 24:
-- 8< --
 octo at leeloo:~ $ grep -r ns_t_sig /usr/include/arpa/
 /usr/include/arpa/nameser_compat.h:#define      T_SIG           ns_t_sig
 /usr/include/arpa/nameser.h:    ns_t_sig = 24,          /* Security signature. */
-- >8 --

The code uses the value of the `__BIND' define to determine which query
types are present. Could you check which value that define has? It'd be
most consistent to check that for that case, too.

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20080607/e0495a54/attachment.pgp 


More information about the collectd mailing list