[collectd] [PATCH] libvirt HostnameFormat is wrong at the moment

Richard W.M. Jones rjones at redhat.com
Wed Jan 9 18:23:42 CET 2008


The attached patch fixes HostnameFormat in libvirt driver.

The intended use for this was:

   HostnameFormat "name"

generating hostnames like "<guestname>" (the default case), and:

   HostnameFormat "hostname name"

generating hostnames like "<hostname>:<guestname>".

Somewhere along the way, however, that code got broken so it always adds 
a ":" before the name, and doesn't concatenate any more, so you'd get 
weird hostnames appearing like ":guest" which was supposed to be 
"hostname:guest".

The patch just reverts back to my original code.

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Build-the-HostnameFormat-by-concatenating-each-field.patch
Type: text/x-patch
Size: 2844 bytes
Desc: not available
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20080109/ec7c5769/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20080109/ec7c5769/attachment-0001.bin 


More information about the collectd mailing list