[collectd] Error during make

[Sebastian Harl]

Hi Sascha,

On Tue, Feb 19, 2008 at 09:27:16AM +0100, Sascha A. Müller wrote:
> >>> Sebastian Harl <sh at tokkee.org> 02/09/08 2:29  >>>
> On Thu, Feb 07, 2008 at 12:03:25PM +0100, Sascha A. Müller wrote:
> >  gcc -DHAVE_CONFIG_H -I. -I. -I. -Wall -Werror -g -O2 -MT hddtemp.lo
> >  -MD -MP -MF .deps/hddtemp.Tpo -c hddtemp.c  -fPIC -DPIC -o
> >  .libs/hddtemp.o
> > hddtemp.c: In function `hddtemp_init':
> > hddtemp.c:307: error: `SCSI_DISK8_MAJOR' undeclared (first use in
> > this function)

> so we only go up to number 7. So no wonder on the compile error.

Oh, I see. The attached patch should fix this issue. Could you please
check, if the same problem applies to IDEX_MAJOR? The patch would have
to be extended then.

> I'm not sure how to tell if the compiler finds the file, but I guess
> it does else i would assume a error regarding SCSI_DISK1_MAJOR and not
> not on SCSI_DISK7_MAJOR. 

Right.

> Dunno if attachments show up on the list, if not I'll see if i can get
> some space on the net.

No attachment showed up, but the mailing list does not block any
attachments.

Cheers,
Sebastian

PS: Please do not use top posting (see [1]) when replying - this breaks
the readability of threads.

[1] http://en.wikipedia.org/wiki/Top-posting

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

-------------- next part --------------
diff --git a/src/hddtemp.c b/src/hddtemp.c
index 8c4bc4a..651de29 100644
--- a/src/hddtemp.c
+++ b/src/hddtemp.c
@@ -314,6 +314,7 @@ static int hddtemp_init (void)
 				case SCSI_DISK5_MAJOR:
 				case SCSI_DISK6_MAJOR:
 				case SCSI_DISK7_MAJOR:
+#ifdef SCSI_DISK8_MAJOR
 				case SCSI_DISK8_MAJOR:
 				case SCSI_DISK9_MAJOR:
 				case SCSI_DISK10_MAJOR:
@@ -322,6 +323,7 @@ static int hddtemp_init (void)
 				case SCSI_DISK13_MAJOR:
 				case SCSI_DISK14_MAJOR:
 				case SCSI_DISK15_MAJOR:
+#endif /* SCSI_DISK8_MAJOR */
 					/* SCSI disks minors are multiples of 16.
 					 * Keep only those. */
 					if (minor % 16)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20080219/f9d3235c/attachment.pgp