[collectd] ipvs patch

[Boian Berberov]

Thanks for the help.  I am attaching an alternative patch.

I did not think it was proper to use a BUILD_WITH_... variable since I did
not see a --with-____ configure option for ipvs.  I followed your second
suggestion with this new patch.

On Mon, Aug 4, 2008 at 15:21, Sebastian Harl <sh at tokkee.org> wrote:

> Hi Boian,
>
> On Mon, Aug 04, 2008 at 02:02:21PM -0600, Boian Berberov wrote:
> > I am writing an updated ebuild for gentoo and I made this patch that
> allows
> > ip_vs.h to be located and the ipvs module to build.
>
> Thanks for your patch. It basically looks fine for me. See a few minor
> comments below though. If you update your patch accordingly, it would
> imho be well suited for inclusion.
>
> > --- configure.in.orig 2008-08-04
> > +++ configure.in      2008-08-04
> > @@ -2332,6 +2338,8 @@
> >       if test "x$have_net_ip_vs_h" = "xyes" -o "x$have_ip_vs_h" = "xyes"
> >       then
> >               plugin_ipvs="yes"
> > +             IPVS_CFLAGS="$ipvs_cflags"
> > +             AC_SUBST(IPVS_CFLAGS)
> >       fi
> >  fi
>
> Usually, those kinds of variables are called BUILD_WITH_<module>_CFLAGS.
> So, to be consistent with the rest of collectd, IPVS_CFLAGS should be
> renamed to BUILD_WITH_IPVS_CFLAGS.
>
> > --- src/Makefile.am.orig      2008-08-04
> > +++ src/Makefile.am   2008-08-04
> > @@ -311,6 +311,7 @@
> >  if BUILD_PLUGIN_IPVS
> >  pkglib_LTLIBRARIES += ipvs.la
> >  ipvs_la_SOURCES = ipvs.c
> > +ipvs_la_CFLAGS = $(IPVS_CFLAGS)
> >  ipvs_la_LDFLAGS = -module -avoid-version
> >  collectd_LDADD += "-dlopen" ipvs.la
> >  collectd_DEPENDENCIES += ipvs.la
>
> Alternatively, you could simply AC_SUBST() KERNEL_DIR and use
> "-I$(KERNEL_DIR)" in Makefile.am directly. I guess, I'd use the latter
> solution but either one is fine for me, so implement whatever you like
> better ;-)
>
> Cheers,
> Sebastian
>
> --
> Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/
>
> Those who would give up Essential Liberty to purchase a little Temporary
> Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFIl3LtEFEKc4UBx/wRAjTuAJ96zCBKglvoJQYzW0IikfrzKVD2wgCfSVbn
> SnqJsvhx8iYgJgZPW32ofQI=
> =Z/E8
> -----END PGP SIGNATURE-----
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.verplant.org/pipermail/collectd/attachments/20080805/9200c3a6/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: collectd-4.4.2-ipvs-alt1.patch
Type: application/octet-stream
Size: 1639 bytes
Desc: not available
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20080805/9200c3a6/attachment.obj