[collectd] [PATCH 1/2] Revert "bindings/Makefile.am: Fix a bug that happened when src and build directory are not the same."

Sebastian Harl sh at tokkee.org
Thu Dec 27 16:39:46 CET 2007


This reverts commit 61f5c1a972626212aab60c4d50f45097485b8e51 which had the
following problems:

 * parts of the build process took place in the source directory (which should
   be read-only though)

 * the "perl" target should not be renamed - the name is used in
   @PERL_BINDINGS@ to identify the bindings that are supposed to be built

Signed-off-by: Sebastian Harl <sh at tokkee.org>
---
 bindings/Makefile.am |   16 +++++++---------
 1 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/bindings/Makefile.am b/bindings/Makefile.am
index 5aa4943..37e31ea 100644
--- a/bindings/Makefile.am
+++ b/bindings/Makefile.am
@@ -1,20 +1,18 @@
 EXTRA_DIST = perl/Collectd.pm perl/Makefile.PL perl/Collectd/Makefile.PL perl/Collectd/Unixsock.pm
 
-PERL_SUBDIR = $(srcdir)/perl
-
 all-local: @PERL_BINDINGS@
 
 install-exec-local:
-	[ ! -f $(PERL_SUBDIR)/Makefile ] || $(MAKE) -C $(PERL_SUBDIR) install
+	[ ! -f perl/Makefile ] || $(MAKE) -C perl install
 
 clean-local:
-	[ ! -f $(PERL_SUBDIR)/Makefile ] || $(MAKE) -C $(PERL_SUBDIR) realclean
+	[ ! -f perl/Makefile ] || $(MAKE) -C perl realclean
 
- at srcdir@/perl: $(PERL_SUBDIR)/Makefile
-	$(MAKE) -C $(PERL_SUBDIR)
+perl: perl/Makefile
+	$(MAKE) -C perl
 
- at srcdir@/perl/Makefile: @srcdir@/perl/Makefile.PL @srcdir@/perl/Collectd/Makefile.PL
-	cd $(PERL_SUBDIR) && @PERL@ Makefile.PL PREFIX=$(prefix) @PERL_BINDINGS_OPTIONS@
+perl/Makefile: perl/Makefile.PL perl/Collectd/Makefile.PL
+	cd perl && @PERL@ Makefile.PL PREFIX=$(prefix) @PERL_BINDINGS_OPTIONS@
 
-.PHONY: @srcdir@/perl
+.PHONY: perl
 
-- 
1.5.3.7.1141.g4eb39

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20071227/4cf109c0/attachment.pgp 


More information about the collectd mailing list