[collectd] PluginRetries

[Justo Alonso]

On Dec 9, 2007 12:36 PM, Sebastian Harl <sh at tokkee.org> wrote:

> Hi Justo,
>
Hi again, Sebastian !

>
>
> (Please reply on-list in the future.)

sorry, I forwarded it later .... but you reply soon .. ;-)


>
> On Sun, Dec 09, 2007 at 11:56:17AM +0100, Justo Alonso wrote:
> > On Dec 5, 2007 8:41 PM, Sebastian Harl <sh at tokkee.org> wrote:
> > > On Wed, Dec 05, 2007 at 04:54:17PM +0100, Justo Alonso wrote:
> > > >     when a plugin read fail, "The time between the calls of the
> function
> > > is
> > > > increased exponentially until one day (86400 seconds)". Maybe a
> > > > "PluginRetries" global parameter can be useful.
> > > >
> > > >    Two option (I think) ...
> > > >          - First, an integer to the max seconds (now hardcoded
> 86400).
> > > >          - Second option is a string with a increment especification
> > > (like
> > > > at mail queue runner), p.e. "F,2h,15m; G,16h,1h,1.5; F,4d,6h" ....
> > >
> > > What kind of benefit would that be for the user? Any such option
> should
> > > not be
> > > hard to implement but I don't really see any benefits from it (besides
> > > confusing most of the users)...
> >
> > Currently, I'm working on a tomcat plugin (soon I  will send you , I'm
> > testing it). When I need stop the tomcat (not-hot deploy, patchs,
> etc...) I
> > need restart collectd. With a 30 seconds interval .. if I stop the
> tomcat by
> > 180 seconds, I have a no-stats period of 480-960 seconds .. ;-(
>
> So, do you need it for testing purposes only? In this case you could
> simply
> make sure, the tomcat read callback returns 0 in all cases.
>

Not, not for testing ... In production environment, some times, you need
stop the service (apache, mysql, tomcat, etc..), for new versions, not
hot-deploys, rotate logs, etc... Now, with the collectd increase interval
method, I need restart the collectd daemon. Not only this plugin .. all
plugins that connect to the service,  if you stop the service for a short
time, you stop the stats for a medium-large time.


> Else it might make more sense (as this seems to be a tomcat-specific
> issue) to
> add an option (to the plugin configuration) to ignore the case when tomcat
> cannot be contacted and return 0 from the read callback in that case. Does
> this sound reasonable to you? Maybe you want to send in a pre-release of
> your
> plugin so we can already have a look at it and discuss it in more detail.
>

I think that this issue is not plugin specific.  Ok ... I will start a new
list thread with the plugin.


>
> > > >    And .. this configuration per plugin ??
> > >
> > > Hum... making this configurable on a per plugin base would make things
> > > somewhat complex - I'm not sure if it's worth the efforts.
> >
> > Maybe a new callback function on the plugin ... interval( int mode, int
> > seconds ). If the callback function is not NULL, when need the interval
> we
> > call to interval function with PLUGIN_INTERVAL_GET mode ... when we need
> > increase interval call it with PLUGIN_INTERVAL_INCREASE mode and when we
> > need reset interval (read function ok), call it with
> PLUGIN_INTERVAL_RESET
> > mode .... If the callback function is NULL all work at this time.
>
> This adds a lot of complexity for (imho) very little benefit. As Florian
> already pointed out, this is not going to happen.


It's ok ... Nobody on the maillist support me, and Florian and you say not
... It's ok .. maybe I'm the only with interest on this issue.

>
>
> > tia, and sorry for my english ;-)
>
> Don't worry - most of us are (I believe) non-native speakers ;-)


Yes, but I seem to sitting bull ... ;-)

Regards,
j


>
> Cheers,
> Sebastian
>
> --
> Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/
>
> Those who would give up Essential Liberty to purchase a little Temporary
> Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFHW9MzEFEKc4UBx/wRAgBJAJ0cbRbnkXgeo8AuhbDOBLg9ep3NLACeOU9/
> X0VFyQiidzUOIEtsbHVnRQU=
> =8SYN
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> collectd mailing list
> collectd at verplant.org
> http://mailman.verplant.org/listinfo/collectd
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.verplant.org/pipermail/collectd/attachments/20071210/2c5ebac5/attachment.htm