[collectd] Re: [PATCH] plugin sensors - small fix reading config, small documentation fix

[Florian Forster]

Hi Lubos,

On Tue, Nov 21, 2006 at 12:20:25PM +0100, Lubo? Stan?k wrote:
> @@ -201,17 +201,20 @@ static int sensors_config (char *key, ch
> -				|| (strcasecmp (value, "On") == 0))
> +				|| (strcasecmp (value, "On") == 0)
> +				|| (strcasecmp (value, "1") == 0))

all plugins *must* support `true' and `false' (because that's how it's
documented in the manpage). Since `on'/`off' and `yes'/`no' are used
regularly, too, plugins *should* support that as well.

I think the choice of options is pretty big as it is and I don't want to
introduce this in *all* plugins. Also, I don't want to have the option
in only one plugin, so I think we're better of without it. If anyone has
a good reason for this change please let me know :)

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20061121/e06df0be/attachment.pgp