[collectd] Proposed patch to extend sensors plugin

Florian Forster octo at verplant.org
Sun Nov 5 17:59:13 CET 2006


Hi Lubos,

On Sun, Nov 05, 2006 at 05:32:43PM +0100, Lubo?? Stan??k wrote:
> > I'll likely reorder the list, too, so it's ordered like this:
> >   fan1, in1, temp1, [...], fan2, in2, temp2, ...
> > The reason being speedup: fan1, in1 and temp1 are likely to appear in
> > the features list, while `temp9' is seldom implemented.
> 
> It would speed up the initialization.
> Good.

oh, you're right. I wasn't aware that it's only used in initialization.
In that case it doesn't matter. If the list is only traversed during
initialization no `clever' (id est complicated but fast) method is
reasonable. I'll simply sort the list in alphabetical order.

> I am sorry for the included patches. I am working on being fluent in
> git all the time. I have been able to "rebase" ls/sensors recently. :)

No problem at all :) You can always try to catch me on ICQ and/or IRC if
you want to ;)

> BTW Do you use "vim" for edits? My editor brakes indentation.

Yes, I do. My setting concerning indentation are (I hope I didn't miss
an important one ;):
  autoindent
  cindent
  shiftwidth=8
  tabstop=8

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20061105/14a090d2/attachment.pgp


More information about the collectd mailing list