[collectd] [PATCH] make traffic plugin only create rrds for selected interfaces

Florian Forster octo at verplant.org
Thu Jun 29 08:10:13 CEST 2006

Hi :)

On Thu, Jun 29, 2006 at 08:18:28AM +0800, Zhuang Yuyao wrote:
> Yes, I am the one who sent you that patch :-). The mail server on
> xianan.com.cn is not stable, sorry for the inconvenience.

I think is wasn't a stability problem, but the fact that the MX record
for the domain is an IP address, not a domain name:

> >   zhuangyy at xianan.com.cn
> >     It appears that the DNS operator for xianan.com.cn
> > has installed an invalid MX record with an IP address
> > instead of a domain name on the right hand side.

 octo at huhu:~ $ host -t MX xianan.com.cn
 xianan.com.cn mail is handled by 1

> Maybe we should add a "Reverse Selection" entry in traffic config to
> let user to choose either ignore specified devices or just monitor
> those devices, because in my special circumstance, the latter is more
> suitable.

Since we have to maintain a list of `selected' (either for inclusion or
exclusion) we might as well let the user decide how to use that list..
Changing the meaning of a config key based on another config key is not
that great, though. I'd suggest using `Include <if>', `Exclude <if>' and
`ByDefault {include|exclude}'. That should be quite obvious how to use.

If you want to work on that, I've copied the patch to the following URL,
since my reply destroyed the patch for you. I don't know if I have the
time to have a look at it soonish, since I have a project to finish up
and I'm already two days late, so I'll have a _very_ busy weekend.

URL of the patch: http://collectd.org/files/patches/

Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20060629/00f1af81/attachment.pgp

More information about the collectd mailing list