[collectd] 3.9.0 build issues..

Christophe Kalt collectd at klb.taranis.org
Tue Apr 18 20:46:38 CEST 2006


Collection of small issues i've encountered on Solaris (x86 &
SPARC):

- if libcurl is not found, apache module needs to be disabled
  (it won't build! ;-)

- nfs is linux specific, so don't try to build on Solaris
  This fails because of -Werror:
  nfs.c:236: warning: `nfs3_procedures_submit' defined but not used

  collectd.c: In function `pidfile_create':
  collectd.c:259: warning: int format, pid_t arg (arg 3)

  i think there was one more issue with -Werror, but i forget

- nanosleep() needs -lrt

- for some reason, autoconf does not find these:
  #define HAVE_NETINET_IN_SYSTM_H 1
  #define HAVE_NETINET_IP_H 1
  #define HAVE_NETINET_IP_ICMP_H 1
  causes ping module to fail to build


Sorry i don't have any patch for these.
Attaching a simple patch to make the df module a bit more
sane.  i think this should all be configurable, i'm just out
of time to make it happen rigth now.

Christophe
-------------- next part --------------
diff -ru collectd-3.9.0/src/df.c collectd-3.9.0+ck/src/df.c
--- collectd-3.9.0/src/df.c	2006-04-18 03:17:10.000000000 -0400
+++ collectd-3.9.0+ck/src/df.c	2006-04-18 14:42:57.105833000 -0400
@@ -114,6 +114,18 @@
 
 	for (mnt_ptr = mnt_list; mnt_ptr != NULL; mnt_ptr = mnt_ptr->next)
 	{
+                if (strcmp(mnt_ptr->type, "autofs") == 0 ||
+                    strcmp(mnt_ptr->type, "ctfs") == 0 ||
+                    strcmp(mnt_ptr->type, "devfs") == 0 ||
+                    strcmp(mnt_ptr->type, "fd") == 0 ||
+                    strcmp(mnt_ptr->type, "lofs") == 0 ||
+                    strcmp(mnt_ptr->type, "mntfs") == 0 ||
+                    strcmp(mnt_ptr->type, "nfs") == 0 ||
+                    strcmp(mnt_ptr->type, "objfs") == 0 ||
+                    strcmp(mnt_ptr->type, "proc") == 0 ||
+                    strcmp(mnt_ptr->type, "tmpfs") == 0)
+                    continue;
+
 		if (STATANYFS (mnt_ptr->dir, &statbuf) < 0)
 		{
 			syslog (LOG_ERR, "statv?fs failed: %s", strerror (errno));


More information about the collectd mailing list