[collectd-changes] collectd, the system statistics collection daemon: Changes to 'master'

Florian Forster octo at verplant.org
Tue May 29 23:52:20 CEST 2018


 src/intel_rdt.c          |   22 +++++++++++-----------
 src/utils_config_cores.c |    2 +-
 src/utils_config_cores.h |    2 +-
 src/virt.c               |    8 ++++----
 4 files changed, 17 insertions(+), 17 deletions(-)

New commits:
commit 9857bf501eac1601a40582e58c05da1f20f613dd
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date:   Tue May 29 18:22:01 2018 +0200

    intel_rdt: fix format specifier
    
    Fixes build on F-26:
    
    src/intel_rdt.c: In function 'rdt_dump_cgroups':
    src/intel_rdt.c:34:20: error: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Werror=format=]
     #define RDT_PLUGIN "intel_rdt"
                        ^
    ./src/daemon/plugin.h:396:42: note: in definition of macro 'DEBUG'
     #define DEBUG(...) plugin_log(LOG_DEBUG, __VA_ARGS__)
                                              ^~~~~~~~~~~
    src/intel_rdt.c:79:11: note: in expansion of macro 'RDT_PLUGIN'
         DEBUG(RDT_PLUGIN ":  group[%d]:", i);
               ^~~~~~~~~~
    src/intel_rdt.c:79:33: note: format string is defined here
         DEBUG(RDT_PLUGIN ":  group[%d]:", i);
                                    ~^
                                    %ld

commit 49c6892bbf13cc546f60310f7550b896b5921f61
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date:   Tue May 29 16:36:44 2018 +0200

    intel_rdt: fix a bunch of warnings
    
      CC       src/intel_rdt_la-intel_rdt.lo
    src/intel_rdt.c: In function ‘rdt_is_core_id_valid’:
    src/intel_rdt.c:163:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
       for (int i = 0; i < g_rdt->pqos_cpu->num_cores; i++)
                         ^
    src/intel_rdt.c:164:17: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
         if (core_id == g_rdt->pqos_cpu->cores[i].lcore)
                     ^~
    src/intel_rdt.c: In function ‘rdt_config_cgroups’:
    src/intel_rdt.c:208:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
       for (int i = 0; i < g_rdt->cap_mon->u.mon->num_events; i++)
                         ^
    src/intel_rdt.c: In function ‘rdt_read’:
    src/intel_rdt.c:389:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
       for (int i = 0; i < g_rdt->num_groups; i++) {
                         ^
    src/intel_rdt.c: In function ‘rdt_init’:
    src/intel_rdt.c:428:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
       for (int i = 0; i < g_rdt->num_groups; i++) {
                         ^
    src/intel_rdt.c: In function ‘rdt_shutdown’:
    src/intel_rdt.c:451:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
       for (int i = 0; i < g_rdt->num_groups; i++) {
                         ^
      CC       src/intel_rdt_la-utils_config_cores.lo
    src/utils_config_cores.c: In function ‘check_core_grouping’:
    src/utils_config_cores.c:166:23: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
         if ((end - start) >= out_size) {
                           ^~
      CCLD     intel_rdt.la

commit c10379655f3ab88a1bfd657eeccc311c3c943f38
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date:   Tue May 29 15:57:00 2018 +0200

    virt plugin: fix a few sign compare warnings
    
      CC       src/virt_la-virt.lo
    src/virt.c: In function ‘domain_state_submit_notif’:
    src/virt.c:1019:29: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
       if ((state < 0) || (state >= STATIC_ARRAY_SIZE(domain_states))) {
                                 ^~
    src/virt.c:1027:31: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
       if ((reason < 0) || (reason >= STATIC_ARRAY_SIZE(domain_reasons[0]))) {
                                   ^~
    src/virt.c: In function ‘fs_info_notify’:
    src/virt.c:1612:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
       for (int i = 0; i < fs_info->ndevAlias; ++i) {
                         ^
    src/virt.c:1587:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
         for (int _i = 0; _i < _size; ++_i) {                                       \
                             ^
    src/virt.c:1619:3: note: in expansion of macro ‘NM_ADD_STR_ITEMS’
       NM_ADD_STR_ITEMS(fs_str_items, STATIC_ARRAY_SIZE(fs_str_items));
       ^~~~~~~~~~~~~~~~
    src/virt.c:1587:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
         for (int _i = 0; _i < _size; ++_i) {                                       \
                             ^
    src/virt.c:1622:3: note: in expansion of macro ‘NM_ADD_STR_ITEMS’
       NM_ADD_STR_ITEMS(fs_dev_alias, fs_info->ndevAlias);
       ^~~~~~~~~~~~~~~~
      CCLD     virt.la




More information about the collectd-changes mailing list