[collectd-changes] collectd, the system statistics collection daemon: Changes to 'master'
Florian Forster
octo at verplant.org
Fri May 18 23:52:21 CEST 2018
Makefile.am | 22 +-
src/collectd.conf.in | 1 +
src/collectd.conf.pod | 6 +
src/daemon/plugin_mock.c | 59 +++
src/valgrind.suppress | 7 +
src/virt.c | 925 +++++++++++++++++++++++++++++++++++-----------
src/virt_test.c | 198 +++-------
7 files changed, 842 insertions(+), 376 deletions(-)
New commits:
commit 38e94dcc796e5d00088826ffd5d43ca5a2e590a2
Merge: 06a86a6 dde2f9e
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri May 18 18:44:38 2018 +0200
Merge pull request #2701 from elfiesmelfie/feat_virt_notify_lifecycle
virt: Fix tracking of VM state changes
commit dde2f9e72ea606ebd0feefd96f17d834f3cea3e5
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Fri May 18 10:48:20 2018 +0100
virt: Cleanup - removed redundant true/false setting
Setting explicitly true/false value in some cases was redundant.
Change-Id: I80bbdcefbf895ca8943c9a9ac45f1bfccf7b2881
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit 9dc817368fe60a6b21c8e05acd605f43c81d97d9
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Thu May 17 11:54:40 2018 +0100
plugin_mock: Mark params as unused in plugin-notification mocks
Change-Id: Iaf1b94849ad689a8e8c683a120a0ecb6cf6a872a
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit 5b5e681e329ec063228b65200f28bda412f91cf9
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Thu May 17 11:51:57 2018 +0100
virt_test: Code cleanup
Removed unnecessary '0'-initialization from static global
variables
Change-Id: Iaf1060dfd8be5e4a81a1e7bcec5cd5a88c0e1516
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit 8172ce014bd37c00138af7e54c5e8311867f6bf3
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Thu May 17 10:00:36 2018 +0100
virt: Change '_Bool' to standard 'bool' type
Change-Id: I11c6d1f9526f22c82b6a375a5fad02209b71e03b
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit c4272df289f722f198b0aaa8d22e5fd787226793
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Wed May 9 12:48:57 2018 +0100
virt: Remove unneeded info about thread id
There is only one notification thread in virt plugin, therefore
information about ID is not needed.
Change-Id: I755f649711a815132927007a80a89caa98704f95
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit b211d8488511f571495a45160635a73cc20dec58
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Tue May 8 15:09:50 2018 +0100
virt: Add valgrind.suppress to EXTRA_DIST
Previosusly newly added valgrind.suppress file was
missing during collectd archive creation using
'make dist-gzip' target.
Virt unit tests were failing on debian wheezy platform
without that file (because of unfiltered libnl v1 leaks).
Change-Id: I49543f883dd6dbeaef439c602b2f05ac0e977053
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit 56322029e2c92fbe29103d0bcc50f544026899c7
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Wed May 2 08:48:34 2018 +0100
virt unit tests: Add valgrind.suppress with libnl1 leak definition
Libnl-1 is used by libvirt on older systems (e.g. debian wheezy)
and unfortunately it has memory leaks that cannot be fixed from
collectd side - virt unit tests were failing on platforms with
libnl1 because of those leaks.
Valgrind.suppress file is used to pass definitions for leaks that
cannot be fixed and now virt unit tests can be run without any
problems on every platform - memory leaks are still validated and
the only difference is that libnl1 leaks are ignored during
valgrind check.
Change-Id: I5fc423402f7b89e4e43fb896f73cba89eea36226
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit 8be68899787276bcd55bf984cad1bea8d49add47
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Mon Apr 23 07:32:35 2018 +0100
virt: Add exit condition in notif-thread loop
Previously thread was stopped using pthread_cancel() call.
Now introduced state variable to track thread active state.
This patch fixes warning about 'infinite loop without
exit condition' generated by Klocwork static analisys.
Change-Id: Ifbaf1dacf422ad6a2a11057e6475c4320c709f33
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit 0a00498519b0fcb15bb4514823003a71d23afa56
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Fri Mar 30 16:31:00 2018 +0100
virt: Fix memory handling for domains data
Memory with data for inactive domains was wrongly
freed earlier in refresh_lists() function and crash
was generated. Memory for active domains have
had the same problems with unnecessary free.
Also added handling for freeing inactive domain in
case of error.
Change-Id: I618798d9a369840be9ee596c96f12cbc1f7b24a6
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit 2710da2f258623ee578db932606c88c8e61a73d8
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Thu Mar 29 08:39:23 2018 +0100
virt: Fix code style in unit tests
Change-Id: I22501153af210082b444103a8c2ae2686064ebfa
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit a3c8ee7061774b1324c313c7b4abbe6fc5680eec
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Tue Mar 27 15:59:13 2018 +0100
virt: Fix memory leak when using libvirt <= 1.0
Cleanup was missing for libvirt-allocated virDomainPtr.
Change-Id: Ied152e9e4084ee9e25b7357e648a6aac8778d09b
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit 6704c1a7200212956fc9d2df639c20e529f37e8f
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Mon Mar 26 11:18:19 2018 +0100
virt: Replace malloc with calloc for array allocations
Change-Id: I5720ea4c4a237eca7aac19e2cdf7a37194c4c69c
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit cf86f1d597d0f3b6646241dc784ec6b89edd6bff
Author: Antoine Naud <antoinex.naud at intel.com>
Date: Wed Mar 21 08:51:42 2018 +0000
src/virt.c: Decouple persistent notifications from refreshInterval
When persistentNotification is true, if refreshInterval value is larger than
(read) Interval, the notifications are not issued every read interval as should
be. The fix consist in decoupling persistent notifications from refreshInterval.
Change-Id: I157554a360510c21ffa631430446afd57b99dfab
Signed-off-by: Antoine Naud <antoinex.naud at intel.com>
commit 1c3f49f2b79d90444615d516420ae1bc506472c9
Author: Antoine Naud <antoinex.naud at intel.com>
Date: Thu Mar 22 09:48:09 2018 +0000
src/virt_test.c: Fix build error on ubuntu:trusty
Change-Id: Ie7dce42f52709c95e1cc51c2236276755278a0ec
Signed-off-by: Antoine Naud <antoinex.naud at intel.com>
commit f8e92a1940f3662f144e5f362521725d0f4d8ec1
Author: Antoine Naud <antoinex.naud at intel.com>
Date: Thu Mar 22 08:31:23 2018 +0000
src/virt_test.c: Fix memory leaks detected by valgrind
src/virt.c: The same memory leaks are also fixed.
Change-Id: Ie970ec5ce500be7cc06512a52994b37cfb687e84
Signed-off-by: Antoine Naud <antoinex.naud at intel.com>
commit 05fb0c23443419b374d877d1c1035fc24ed7dda5
Author: Antoine Naud <antoinex.naud at intel.com>
Date: Wed Mar 14 11:49:13 2018 +0000
src/virt.c: Fix build error on ubuntu:trusty
Change-Id: Ic76a5b9861360181c677b643245b24f40b80777b
Signed-off-by: Antoine Naud <antoinex.naud at intel.com>
commit 1faf3478bc1e3fedea3781510554277876429793
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Wed Mar 7 14:40:35 2018 +0000
virt: Fix unit tests build with libvirt versions < 1.3
Previously too much code was disabled in ifdefs, and during
compilation with old libvirt (version < 1.3.x) warning was shown
because of unused test variables.
Change-Id: I631c9446add4ccef068a3c4585f8750a5930f406
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit 91a079ffdfe4ccc89bd1b57d37a4389dabc08022
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Wed Mar 7 09:55:56 2018 +0000
plugin_mock: Fix code formatting after virt-plugin related changes
Change-Id: I759724b3b6ae9e2f62a66f82e59ca4ca29cc1db9
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit fc97d457c96b48a456e80d29f52b53d117f8e1b6
Author: Antoine Naud <antoinex.naud at intel.com>
Date: Fri Mar 2 15:00:01 2018 +0000
src/virt.c: Enable support for libvirt-1.3.1
Several macros are added to the definition of map_domain_event_detail_to_reason.
One unnecessary #ifdef macro is removed.
Change-Id: I5357816caa11009fbfee076524e03cdf2eb06109
Signed-off-by: Antoine Naud <antoinex.naud at intel.com>
commit 28a8eeb9eda5a014acf0ebc1797050cd2d1bcc89
Author: Antoine Naud <antoinex.naud at intel.com>
Date: Thu Feb 22 14:21:50 2018 +0000
src/virt.c: Fix security issue detected by klocwork related to strncat
The fix consist in replacing all strncat invocations
with safer macro SSTRNCAT.
Change-Id: I4faee764762f8881d7f7539db6359685b910da44
Signed-off-by: Antoine Naud <antoinex.naud at intel.com>
commit a8165663bf8c431a7c3b15a1863b65e24f4b77fd
Author: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
Date: Fri Feb 16 13:58:36 2018 +0000
virt: Apply formatting rules on plugin code
Code formatted with contrib/format.sh script.
Change-Id: I49ad8bc48af11a09779027df7855e042e8d9de37
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski at intel.com>
commit 7325774e210ab695351723e56a32dd3679af2032
Author: Mozejko, MarcinX <marcinx.mozejko at intel.com>
Date: Mon Nov 27 10:57:50 2017 +0000
virt: Fix build error
Change-Id: I6b1111aded6391775a40911fdede288b3f0380d9
Signed-off-by: Mozejko, MarcinX <marcinx.mozejko at intel.com>
commit b3d9acd7091f9f48e1c35f7229c8fac405c75483
Author: Mozejko, MarcinX <marcinx.mozejko at intel.com>
Date: Mon Nov 6 10:03:18 2017 +0000
virt: Add domain state metrics dispatch
Previously information about Virtual Machine domains state
(e.g. VIR_DOMAIN_RUNNING, VIR_DOMAIN_PAUSED..) was not
dispatched (e.g. file with domain states was not created by
CSV plugin).
Now current VM state information with corresponding reason is
dispatched as ‘domain_state’.
Change-Id: I781f11f53adb9ca0abcf6565d5717c6495f853b7
Signed-off-by: Mozejko, MarcinX <marcinx.mozejko at intel.com>
commit db6d9797d4f4976721549614d5400bf9cadd4cac
Author: Antoine Naud <antoinex.naud at intel.com>
Date: Thu Sep 14 11:14:28 2017 +0100
src/virt.c: State notifications for all persistent domains
When virt option PersistentNotification is enabled, the notifications of VMs
states are sent only for running VMs (whereas they should be sent for all
persistent VMs, including running, suspended, shut off VMs). This behaviour is
due to the fact that VM states are notified while fetching all other metrics,
which is executed only for running VMs.
This commit fixes this issue by decoupling the notifications of VMs states from
fetching and dispatching metrics values. In this purpose, a new function named
persistent_domains_state_notification is added to fetch the states (and reasons)
of persistent VMs and notify them. This function is called at each read interval
before fetching and dispatching the metrics from running VMs.
Unit Tests for the new functions are implemented.
Change-Id: Ic2befb3e7826184696344b037916bc603ec01341
Signed-off-by: Antoine Naud <antoinex.naud at intel.com>
commit 1ce900790385724fdef0baabed4b36e2dd630d8e
Author: Antoine Naud <antoinex.naud at intel.com>
Date: Mon Aug 28 10:55:19 2017 +0100
src/virt.c: add lifecycle transition notifications
Notifications about VM state are received on every read interval, so the same
notification about specific VM state is received several times within a minute,
which lead to growing log files. This issue is fixed by generating notifications
only for VM state changes (denoted also here lifecycle transitions).
This commit adds a binary option PersistentNotification to virt plugin. When
this option is set to false (default value), only VM state changes are notified
as soon as they occur. When this option is set to true, VM states are notified
on every read interval.
Change-Id: I46ebe2d2f1b72432e7b458530c4cc0eac3e26c6a
Signed-off-by: Antoine Naud <antoinex.naud at intel.com>
More information about the collectd-changes
mailing list