[collectd-changes] collectd, the system statistics collection daemon: Changes to 'master'

[Florian Forster]

 src/collectd.conf.pod            |  70 +++++++++++++++++++++++---
 src/curl.c                       |  66 +++++++++----------------
 src/curl_json.c                  |  13 ++---
 src/curl_xml.c                   |   6 ++-
 src/daemon/configfile.c          |   1 +
 src/daemon/plugin.c              |  43 ++++++----------
 src/dbi.c                        |  10 ++--
 src/modbus.c                     |  10 ++--
 src/oracle.c                     |   3 +-
 src/postgresql.c                 |  16 +++---
 src/redis.c                      |   2 -
 src/snmp.c                       |  14 ++----
 src/tail.c                       |  74 +++++++---------------------
 src/tail_csv.c                   |  10 ++--
 src/utils_db_query.c             |  12 +----
 src/utils_db_query.h             |   2 +-
 src/utils_format_graphite.c      | 103 ++++++++++++++++++++++++++++++++++++---
 src/utils_format_graphite.h      |   1 +
 src/utils_format_graphite_test.c |  16 ++++++
 src/utils_tail_match.c           |  13 +----
 src/utils_tail_match.h           |  24 ++++-----
 src/write_graphite.c             |   3 ++
 src/write_kafka.c                |   4 ++
 23 files changed, 283 insertions(+), 233 deletions(-)

New commits:
commit e9c6bf25649bb8ead1bf383e51426b6552f08251
Merge: 81bda22 e53ab7f
Author: Pavel Rochnyak <pavel2000 at ngs.ru>
Date:   Thu Jul 5 10:41:18 2018 +0700

    Merge pull request #2631 from DanCech/tagged-carbon
    
    Graphite 1.1+ tag support

commit 81bda22a4ebb3f60bf665048517ce65d77cc6501
Merge: 8a9e349 1c4f1be
Author: Pavel Rochnyak <pavel2000 at ngs.ru>
Date:   Thu Jul 5 10:38:33 2018 +0700

    Merge pull request #2847 from rpv-tomsk/collectd-master
    
    tree-wide: Use interval value from plugin context, do not set 'vl->interval' in plugins more.

commit 8a9e349b729ca8aa3144340b5b0fe85183597e06
Merge: 7262629 85fd55f
Author: Pavel Rochnyak <pavel2000 at ngs.ru>
Date:   Thu Jul 5 10:37:36 2018 +0700

    Merge pull request #2845 from rpv-tomsk/tmpfix
    
    redis plugin: Remove `operations_per_second` metric.

commit e53ab7ffa52682fa59882ebaeb4489315d3c3832
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 20:09:26 2018 +0700

    write_kafka: Added Graphite tag support

commit 1ae2c06ca9744a592696115b69c1d8785a4bd7f7
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 19:52:04 2018 +0700

    write_graphite: Documented 'UseTags' option

commit 149a201c8e5d4dd0a39334b34cf293c7fb967fd8
Author: Jacob Lisi <jacob.t.lisi at gmail.com>
Date:   Tue Nov 7 16:29:38 2017 -0500

    utils_format_graphite: add tests for graphite tag flag

commit 5fccaaf2d371bef9d088591c92f466f0c8edd33c
Author: Dan Cech <dcech at grafana.com>
Date:   Tue Oct 31 12:40:43 2017 -0400

    utils_format_graphite: Add graphite tag support

commit 1c4f1be13d46339d88245f69f67d5cd1e7456ce5
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 14:47:18 2018 +0700

    curl plugin: Added 'Interval' option

commit 4e2dfc0593d5fc3f28a096cd94f592758eace039
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 14:20:54 2018 +0700

    curl_xml plugin: Added 'Interval' option

commit 5b979ffa2721f7b8f2a64af2b9b42c9d5f2d690f
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 14:13:36 2018 +0700

    core: Added plugin name to (some) error reporting

commit 338db8de5f2cc289641f5f947f0fa1ef4070c3f2
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 13:17:21 2018 +0700

    tree-wide: Use interval value from plugin context

commit a58ed75245f03924612a98745cba74f3464b4d77
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 13:15:48 2018 +0700

    core: Cleanup in vl->interval assignment

commit 62e9fd1e6b8e29d187f771f82820a3070bec0156
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 12:43:10 2018 +0700

    core: Set plugin name in context when plugin is autoloaded

commit 799fe057abbbd81b2d0b3e41fb90dd8e52ba4952
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 12:00:02 2018 +0700

    core: Set 'interval' value in plugin context to match read callback interval

commit adc792f3ef14550fedcf2b3d160102fd6db69dfc
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 11:33:04 2018 +0700

    postgresql: Set correct value to 'interval' query parameter (bugfix)

commit a369de205538191d4c23af2277f6ba0b2039f076
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 10:46:09 2018 +0700

    utils_tail_match: Updated formatting

commit 8da2d75750b2920231be36df0341eea9209bc5f7
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Jul 4 10:43:17 2018 +0700

    utils_tail_match: Removed unused variables

commit 654b06707840cb46b1b15171d994bd86a6f40335
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Tue Jul 3 18:48:02 2018 +0700

    utils_tail_match: Fix formatting

commit 85fd55f0c419cfd23aef9a408e8a0167aca9e4d5
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Sun Jul 1 13:52:31 2018 +0700

    redis plugin: Remove `operations_per_second` metric.
    
    The `operations_per_second` metric removed as duplicate of other metric and as
    it has wrong value also. Collectd should not report wrong values.
    
    Metric `operations_per_second` is based on `instantaneous_ops_per_sec` field
    from Redis `INFO` output. That field is calculated based on buffer of 16 values,
    updated from `stat_numcommands` once per 100ms.
    So, `instantaneous_ops_per_sec` value has average only for last 1.6 seconds.
    While Collectd poll period is 10 seconds, statistics for 8.4 seconds is lost.
    
    Herewith, Collectd already has correct metric `total_operations`, based on
    `total_commands_processed` field taken from same `stat_numcommands` internally
    in Redis. Value of this metric should be used instead of removed metric.