[collectd-changes] collectd, the system statistics collection daemon: Changes to 'master'

Florian Forster octo at verplant.org
Wed Sep 27 22:24:50 CEST 2017


 src/snmp.c |   43 +++++++++++++++++++++++++++++++++++++++----
 1 file changed, 39 insertions(+), 4 deletions(-)

New commits:
commit df6a1dedda953cb34fc4d16d390c823021d0916d
Merge: db74224 81eeac6
Author: Florian Forster <octo at collectd.org>
Date:   Wed Sep 27 22:24:21 2017 +0200

    Merge remote-tracking branch 'github/pr/2449'

commit 81eeac695e82db28b2e5a38ca0947650c43cf028
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Sep 27 19:15:13 2017 +0700

    snmp plugin: Use array instead of cycle in res->errstat check

commit 1eef4102557312f19400b8655f054c4fdb7311e4
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Wed Sep 27 02:01:14 2017 +0700

    snmp plugin: Reworked/fixed res->errstat check

commit 9816488b3c779b85e285956e8a920bfceac43840
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date:   Thu Jun 1 14:39:24 2017 +0700

    snmp plugin: Added res->errstat check
    
    Collectd does not check for `res->errstat` value after
    `snmp_sess_synch_response()` call. In case of error, there is no any data in
    `res->variables` actually, but variables are tried to be processed as usual.
    Suffix calculation will fail, so all subtrees will be marked as failed, not
    only one subtree which caused an error.
    
    The csnmp_instance_list_add() call will fail too, and, as result,
    `csnmp_read_table` will finish it's work without any data submission.
    
    The log message like
    "snmp plugin: host HOSTNAME: csnmp_instance_list_add failed",
    which is put into logs in this case, also has no enough diagnostic data.
    
    Added code to proper check for `res->errstat` and to try to get available data.
    
    Issue: #2291




More information about the collectd-changes mailing list