[collectd-changes] collectd, the system statistics collection daemon: Changes to 'master'

Sat Nov 18 09:56:52 CET 2017

 configure.ac                           |   33 +--
 src/collectd.conf.in                   |    2 +-
 src/collectd.conf.pod                  |    2 +-
 src/daemon/meta_data.c                 |    1 -
 src/gps.c                              |    1 -
 src/libcollectdclient/network_buffer.c |    4 +
 src/libcollectdclient/network_parse.c  |   17 ++
 src/mcelog.c                           |    8 +-
 src/ovs_events.c                       |    4 +-
 src/ovs_stats.c                        |  117 +++++-----
 src/postgresql_default.conf            |   17 +-
 src/processes.c                        |    2 +-
 src/snmp.c                             |    6 +-
 src/snmp_agent.c                       |   11 +-
 src/target_notification.c              |    4 +-
 src/utils_ovs.c                        |   30 +--
 src/utils_tail_match.c                 |    9 +-
 src/varnish.c                          |  391 ++++++++++++++++++--------------
 src/write_riemann.c                    |    1 +
 src/zfs_arc.c                          |   27 +--
 20 files changed, 388 insertions(+), 299 deletions(-)

New commits:
commit 22813e1a6a3d059efc67975893df985052661a7a
Merge: 161388c 8fd8f76
Author: Florian Forster <octo at collectd.org>
Date:   Sat Nov 18 09:56:30 2017 +0100

    Merge branch 'collectd-5.8'

commit 8fd8f76dc11064e75e44448d16d35e09e46191a2
Merge: ce13502 5f6d3ce
Author: Florian Forster <octo at collectd.org>
Date:   Sat Nov 18 09:55:58 2017 +0100

    Merge branch 'collectd-5.7' into collectd-5.8

commit ce13502b2a127ec38f851422cb8b0ccf0da5e52a
Merge: ec17979 1cc7599
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 18:32:21 2017 +0100

    Auto-Merge pull request #2555 from octo/cid/179231
    
    Automatically merged due to "Automerge" label

commit 5f6d3ce21d3b59e2ee6bc05cca6390a746cf2524
Merge: f123d38 4fdd719
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 18:20:21 2017 +0100

    Auto-Merge pull request #2554 from octo/cid/179227
    
    Automatically merged due to "Automerge" label

commit ec17979a1dad5130174b349d7867870848e5e9e3
Merge: 7a18567 e896272
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 18:04:45 2017 +0100

    Auto-Merge pull request #2553 from octo/cid/179230
    
    Automatically merged due to "Automerge" label

commit 1cc759929dcd25ae204452648ebb16a3ceb8c3b1
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 17:26:28 2017 +0100

    ovs_stats plugin: Fix null dereference of "port".
    
    This also refactors the ovs_stats_update_iface_ext_ids() function to
    handle errors, instead of many nested if blocks.
    
    CID: 179231

commit 4fdd7193481b638a059d6fa047542312e41ea45e
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 17:16:39 2017 +0100

    write_riemann plugin: Unlock mutex before destroying it.
    
    CID: 179227

commit e896272076a377c1a401e0237e182b689f819cf7
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 17:11:32 2017 +0100

    processes plugin: Fix check for context switch counters.
    
    CID: 179230

commit 7a18567e6dd707f6d1d1367be5a970b3dc5fef56
Merge: b27690f 47cb204
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 16:44:07 2017 +0100

    Auto-Merge pull request #2550 from octo/cid/179234
    
    Automatically merged due to "Automerge" label

commit b27690f1217ac112e5a98cd2fc77facad9df26fc
Merge: a44b08a 355df25
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 16:32:19 2017 +0100

    Auto-Merge pull request #2549 from octo/cid/179240
    
    Automatically merged due to "Automerge" label

commit a44b08a5204c52e231d78a43a08a1aeab356c758
Merge: ce5436d 446184c
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 16:20:46 2017 +0100

    Auto-Merge pull request #2548 from octo/cid/42796
    
    Automatically merged due to "Automerge" label

commit f123d3873170fb2bc06a1ea03396e57128d2ab63
Merge: 4962291 8ec942a
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 16:08:50 2017 +0100

    Auto-Merge pull request #2547 from octo/cid/81390
    
    Automatically merged due to "Automerge" label

commit 47cb204f324be21ae54084fbe9e338d854b87bf5
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 15:38:59 2017 +0100

    ovs_stats plugin: Minor code cleanup.

commit b4e3ffe8633858d01f00a8654823baa55ecf6288
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 15:37:57 2017 +0100

    ovs_stats plugin: Add missing unlock.
    
    CID: 179234

commit 355df251d423992fd52b602535d1ae92daffc9c0
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 15:29:07 2017 +0100

    src/utils_ovs.c: Random coding style improvements.

commit 85018547508ae2adb331aa74139acac91f24ff42
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 15:28:39 2017 +0100

    src/utils_ovs.c: Don't set pthread_t to -1, use pthread_equal() to compare.
    
    The assumption that pthread_t is a scalar is not portable.

commit 461a11ee1d46140244c79b4dff3b978426187f94
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 15:26:13 2017 +0100

    src/utils_ovs.c: Unlock pdb->mutex before calling ovs_db_callback_remove_all().
    
    CID: 179240

commit 4962291342f14fecbc6bb0240bd8ec7c76e2fc64
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 15:15:32 2017 +0100

    gps plugin: Fix double unlock.
    
    CID: 179241

commit 446184cb9cf0b21d3e387d426f2249d4a8aa0557
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 15:09:59 2017 +0100

    zfs_arc plugin: Allocate ksp later to avoid memory leak.
    
    CID: 42796

commit ce5436d10d28b9d8c2cb204726e36823df2c6766
Merge: ac0af6c bcf9c48
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 15:05:35 2017 +0100

    Auto-Merge pull request #2546 from octo/cid/179229
    
    Automatically merged due to "Automerge" label

commit 8ec942a6f2ac84b193bcc1a286671b7afcb1e86d
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 14:56:06 2017 +0100

    snmp plugin: Ensure that index is within bounds.
    
    CID: 81389, 81390

commit bcf9c488e832b4cba43b1c1e35d58f463feb967f
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 14:34:39 2017 +0100

    ovs_stats plugin: Fix a memory leak.
    
    br_name would leak when jumping to cleanup_fail.
    
    CID: 179229

commit ac0af6c500b4474a530302794cd8e722ddf30900
Merge: 26442d5 eba50a3
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 14:29:29 2017 +0100

    Auto-Merge pull request #2540 from octo/cid/141009
    
    Automatically merged due to "Automerge" label

commit 26442d500face649a45d9ca6c36fb87b3a6972ea
Merge: 2ed0f6b 6130f4c
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 14:16:58 2017 +0100

    Auto-Merge pull request #2539 from octo/cid/179243
    
    Automatically merged due to "Automerge" label

commit 2ed0f6b448f7248c9b78425181d5acddfa35e72f
Merge: 7c2336d 7a8ce49
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 14:05:01 2017 +0100

    Auto-Merge pull request #2538 from octo/cid/179244
    
    Automatically merged due to "Automerge" label

commit eba50a34e2ca4c0823a5cb826c4e2123dab30e7f
Author: Florian Forster <octo at collectd.org>
Date:   Wed Nov 15 22:26:11 2017 +0100

    libcollectdclient: Ensure vl->values_len is non-zero.
    
    That size_t is then used to declare Variable Length Arrays. Hopefully
    this helps to convince Coverity that pkg_values and pkg_values_types are
    actually fully initialized.
    
    CID: 141009, 141010

commit 6130f4c3463d299e7c89032a9532641ee057e203
Author: Florian Forster <octo at collectd.org>
Date:   Wed Nov 15 22:03:53 2017 +0100

    ovs_events plugin: Replace strncpy() with sstrncpy().
    
    CID: 179243

commit 7a8ce497dc369ffee8d942616e808a5abfca9d3e
Author: Florian Forster <octo at collectd.org>
Date:   Wed Nov 15 21:38:32 2017 +0100

    snmp_agent plugin: Fix memory leak.
    
    Allocate "entry" later so that the error handling blocks don't leak it.
    
    CID: 179244

commit 7c2336dde35a7b42853b6ca167d4164619e52333
Merge: 1f684bf 6b91766
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 13:18:00 2017 +0100

    Merge branch 'collectd-5.7' into collectd-5.8

commit 6b91766963f80e75cbbb3f17fbdf357f80e7c7b6
Merge: ec613f7 5d19395
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Fri Nov 17 13:15:19 2017 +0100

    Auto-Merge pull request #2545 from octo/turbostat
    
    Automatically merged due to "Automerge" label

commit 5d1939524113c6103e21b5d49bfe1fcb357f1a8a
Author: Florian Forster <octo at collectd.org>
Date:   Fri Nov 17 11:51:43 2017 +0100

    contrib/format.sh src/msr-index.h src/turbostat.c

commit e74581f29cff39f49799f1e3c0b500029452b033
Author: Vincent Brillault <git at lerya.net>
Date:   Tue Sep 26 19:34:03 2017 +0200

    msr-index: include GPLv2 header
    
    Signed-off-by: Florian Forster <octo at collectd.org>

commit cba183dbc6030501446c2a7134200f5f3739152b
Author: Vincent Brillault <git at lerya.net>
Date:   Mon Sep 25 21:21:45 2017 +0200

    turbostat: import msr-index header from linux
    
    Since Linux 4.12, the kernel does not expose msr-index.h to the userland
    anymore. This commit pulls and hardcode the required definitions.
    
    Signed-off-by: Florian Forster <octo at collectd.org>

commit ec613f7fe32e45de07333a2de8343ea69ac474cd
Author: Florian Forster <octo at collectd.org>
Date:   Wed Nov 15 22:31:47 2017 +0100

    src/daemon/meta_data.c: Fix double unlock.
    
    CID: 179245

commit 9c6a92b8a30d63f6b476ab0bf0d166f3de41a7b1
Author: Feike Steenbergen <feike.steenbergen at adyen.com>
Date:   Wed Nov 15 08:46:57 2017 +0100

    Fix documentation typo for PostgreSQL plugin
    
    In collectd/src/postgresql_default.conf the name for the backends
    query is plural, yet in the documentation it is singular. This caused
    me some lost time when running this plugin.
    
    It is also wrongly listed on the wiki:
    
    https://collectd.org/wiki/index.php/Plugin:PostgreSQL
    Signed-off-by: Florian Forster <octo at collectd.org>

commit 1f684bf755acedd26fd0ff18f8cbc5fa0e2b15fc
Merge: c59ab24 7b26a3e
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Tue Nov 14 23:08:48 2017 +0100

    Auto-Merge pull request #2535 from mfournier/collectd-5.8
    
    Automatically merged due to "Automerge" label

commit 7b26a3ea1026b81cf8a12fc72649d07e7b5f453a
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date:   Tue Nov 14 22:21:33 2017 +0100

    mcelog: filter through contrib/format.sh

commit 196f5bd17880d91ba0da33a8f5f6168d039cfa0c
Merge: 6f5b757 19b51c4
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date:   Tue Nov 14 22:15:11 2017 +0100

    Merge branch 'collectd-5.7' into collectd-5.8

commit 6f5b7579b9ebe88da901b8ba5c50fc3793d2be73
Author: Taras Chornyi <tarasx.chornyi at intel.com>
Date:   Tue Nov 14 17:21:36 2017 +0000

    Fixed code styling
    
    Signed-off-by: Taras Chornyi <tarasx.chornyi at intel.com>

commit f46d76e976ed76d2d8fa297918ecd308680d7ae9
Author: Taras Chornyi <tarasx.chornyi at intel.com>
Date:   Tue Nov 14 17:17:20 2017 +0000

    Fixed gcc 7 format-truncation errors #2423
    
    Signed-off-by: Taras Chornyi <tarasx.chornyi at intel.com>

commit c59ab241c4837cf826a6433a240385bb761d7c4a
Merge: fc9f78c 890f917
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Sun Nov 12 22:04:11 2017 +0100

    Auto-Merge pull request #2517 from trustchk/aix
    
    Automatically merged due to "Automerge" label

commit 890f917d8e907420f884a8d45af734575e13037c
Author: Florian Forster <octo at collectd.org>
Date:   Thu Nov 9 16:42:22 2017 +0100

    libcollectdclient/network_parse.c: Implement be{16,64}toh() if not provided by the system.

commit fc9f78c625e248d67a1147ac684c39b4bb951ee5
Merge: d4db3dc c1e2bf3
Author: collectd bot <32910397+collectd-bot at users.noreply.github.com>
Date:   Thu Nov 9 17:08:53 2017 +0100

    Auto-Merge pull request #2527 from mfournier/varnish_52_compat_on_collectd_58
    
    Automatically merged due to "Automerge" label

commit c1e2bf3d2bfa1a1da3a6b42186577f635795e7f8
Author: Florian Forster <octo at collectd.org>
Date:   Thu Nov 9 16:18:33 2017 +0100

    varnish plugin: Code cleanup:
    
    *   Remove legacy rindex() with the POSIX strrchr().
    *   Check return value of strrchr().
    *   Chose non-arbitrary buffer size.
    *   Use sstrncpy() instead of strcpy().

commit 8192bfcf975ff6275505c99193a23e2a066927d0
Author: Florian Forster <octo at collectd.org>
Date:   Thu Nov 9 16:12:10 2017 +0100

    varnish plugin: Avoid unused variable even harder.
    
    ;-)

commit 68123637814ea09efff5bf56f3209eefbe41287a
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date:   Wed Nov 8 22:01:26 2017 +0100

    varnish plugin: avoid unused variable in V5 block

commit 7978b43670472a000831f7ff37a6a30771a6ee6f
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date:   Wed Nov 8 21:55:04 2017 +0100

    varnish plugin: fix build against pre varnish 5.2
    
    Older Varnish versions don't know about VSM_Destroy()

commit 3ab73ae8b23b9816fb69fde630c5ad667aa1e09f
Author: Denes Matetelki <dmatetelki at varnish-software.com>
Date:   Wed Nov 8 14:39:38 2017 +0100

    running contrib/format.sh on src/varnish.c

commit 3c42182e912e3d634fe8c4f6a636053959fcde49
Author: Denes Matetelki <dmatetelki at varnish-software.com>
Date:   Wed Nov 8 14:30:20 2017 +0100

    varnish-cache-5.2 compatibility

commit 19b51c4abd9dbff16fb69d7eb84422f31c6130bc
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date:   Wed Nov 8 17:26:51 2017 +0100

    postgresql: fix last sum() related parse errors
    
    These queries return empty values when a database doesn't have any
    tables yet, which results in collectd logging this error every Interval:
    
    ```
    db query utils: udb_result_submit: Parsing `' as derive failed.
    ```
    
    Related to #1905

commit c572f404273814ab51cc2590cbd33f7ae2c51c39
Author: trustchk <trustchk at users.noreply.github.com>
Date:   Thu Nov 2 15:03:21 2017 +0000

    libcollectdclient: add defines for AIX
    
    This adds two defines that are missing on AIX because they don't have
    the endian.h header file. AIX is always big endian, so no further check
    is required for that. As I have no access to IBMs XLC compiler, this
    patch limits the definitions to GNU GCC.