[collectd-changes] collectd, the system statistics collection daemon: Changes to 'collectd-5.6'
Florian Forster
octo at verplant.org
Mon May 15 08:14:20 CEST 2017
src/collectd.conf.pod | 8 +++----
src/perl.c | 56 ++++++++++++++++++++++++++++---------------------
2 files changed, 36 insertions(+), 28 deletions(-)
New commits:
commit b40f741f7f4c0f20d4ec6ad331ab242e81d9f76c
Author: Florian Forster <octo at collectd.org>
Date: Mon May 15 08:14:03 2017 +0200
collectd.conf(5): Fix typo ("queries" vs. "queried").
By avoiding the word: "metrics" is bettern than "statistics".
commit 7d6d77abad82af9b9c7df77948af345e3b7755fc
Merge: c3e2a69 867e977
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun May 14 12:38:58 2017 +0200
Merge pull request #2278 from octo/ff/perl
perl plugin: Fix potential double-free.
commit 867e977f14bdb55dd2c727a8b9b5f6aaac41e558
Author: Florian Forster <octo at collectd.org>
Date: Sun May 14 08:24:51 2017 +0200
perl plugin: Fix potential double-free.
The av2notification_meta() function updated it's parameter by doing
(*m) = malloc();
Afterwards, if an error occurred, it would call `free(*m);` and (potentially)
return, leaving an invalid pointer stored in `m`. The caller would then try to
free the returned pointer because it was non-NULL.
This patch fixes this by doing several code cleanups:
* The meta argument is not updated unnecessarily. Instead, a local variable
is allocated and used within the loop and only on success is the return
pointer updated.
* Introduce additional local variables instead of re-using the `tmp` variable
multiple times.
* Name the variable pointing to the end of the linked list appropriately
`tail` and remove one level of indirection. Reading code that is using
pointers to pointers is unnecessarily hard.
More information about the collectd-changes
mailing list