[collectd-changes] collectd, the system statistics collection daemon: Changes to 'master'
Florian Forster
octo at verplant.org
Fri Oct 28 07:23:32 CEST 2016
ChangeLog | 24 +++
contrib/redhat/collectd.spec | 36 ++++-
src/Makefile.am | 22 ++-
src/aggregation.c | 4 +-
src/amqp.c | 16 +-
src/bind.c | 72 ++++-----
src/collectd-snmp.pod | 6 +-
src/collectd.conf.pod | 20 +--
src/curl.c | 6 +-
src/daemon/collectd.c | 3 +-
src/daemon/common.c | 38 +++--
src/daemon/common.h | 3 +-
src/daemon/plugin.c | 8 +-
src/daemon/plugin.h | 10 ++
src/daemon/plugin_mock.c | 15 ++
src/daemon/utils_cache.c | 113 +++++--------
src/daemon/utils_cache_mock.c | 12 ++
src/daemon/utils_time.c | 14 +-
src/daemon/utils_time.h | 107 ++++++++-----
src/daemon/utils_time_test.c | 7 +-
src/dns.c | 26 +--
src/dpdkstat.c | 19 +--
src/exec.c | 2 +-
src/gps.c | 29 ++--
src/log_logstash.c | 4 +-
src/logfile.c | 5 +-
src/lua.c | 2 +-
src/nginx.c | 34 ++--
src/notify_email.c | 4 +-
src/openldap.c | 2 +-
src/postgresql_default.conf | 16 +-
src/powerdns.c | 28 ++--
src/processes.c | 152 ++++++++----------
src/rrdcached.c | 106 ++++++++++---
src/rrdtool.c | 2 +-
src/tail_csv.c | 2 +-
src/testing.h | 5 +-
src/unixsock.c | 8 +-
src/utils_cmd_flush.c | 186 ++++++++++++++--------
src/utils_cmd_flush.h | 12 +-
src/utils_cmd_getthreshold.c | 3 +-
src/utils_cmd_getval.c | 150 ++++++++++--------
src/utils_cmd_getval.h | 10 +-
src/utils_cmd_listval.c | 62 +++++---
src/utils_cmd_listval.h | 10 +-
src/utils_cmd_putval.c | 243 +++++++++++++++++-----------
src/utils_cmd_putval.h | 11 +-
src/utils_cmds.c | 352 +++++++++++++++++++++++++++++++++++++++++
src/utils_cmds.h | 211 ++++++++++++++++++++++++
src/utils_cmds_test.c | 320 +++++++++++++++++++++++++++++++++++++
src/utils_vl_lookup.c | 6 +-
src/utils_vl_lookup.h | 6 +-
src/utils_vl_lookup_test.c | 14 +-
src/valgrind.FreeBSD.suppress | 2 +-
src/vserver.c | 29 ++--
src/write_http.c | 2 +-
src/write_kafka.c | 4 +-
src/write_redis.c | 2 +-
version-gen.sh | 2 +-
59 files changed, 1892 insertions(+), 727 deletions(-)
New commits:
commit 19a7c076959e16df16be966d4c3aa563431ef038
Merge: 538f8ff 661bf77
Author: Florian Forster <octo at collectd.org>
Date: Fri Oct 28 07:22:59 2016 +0200
Merge remote-tracking branch 'github/pr/2006'
commit 538f8ff488573b173eee3f36a37c89b0c2b75321
Merge: e1fda36 2ede5e7
Author: Florian Forster <octo at collectd.org>
Date: Thu Oct 27 21:29:43 2016 +0200
Merge remote-tracking branch 'github/pr/2001'
commit 661bf777b32b7df979586ac1e31eb22217d00049
Author: Florian Forster <octo at collectd.org>
Date: Thu Oct 27 21:19:35 2016 +0200
curl plugin: Don't use CDTIME_T_TO_DOUBLE() within a composite literal.
GCC 4.6 has a problem with the original code:
curl.c: In function 'cc_submit_response_time':
curl.c:644:26: internal compiler error: Segmentation fault
This is essentially a shot in the dark, trying to fix this issue.
commit 70b606111981cebf7c581c945118022a4f416577
Author: Florian Forster <octo at collectd.org>
Date: Wed Oct 26 22:48:51 2016 +0200
gps plugin: Replace busy loop with pthread_cond_timedwait().
commit 4d86011a91b7fe05fd5f4d84fa88c19d8c031110
Author: Florian Forster <octo at collectd.org>
Date: Wed Oct 26 20:59:32 2016 +0200
Various: Simplify code using composite literals.
commit e1fda36ff7e4b5f508b630b614b182e298d91fb7
Merge: bf70b5b 1cc8a40
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Wed Oct 26 19:33:44 2016 +0200
Merge branch 'collectd-5.6'
commit 1cc8a409058863e20747513d057d5ac471fe1382
Merge: 5e4f2ae a92b550
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Wed Oct 26 19:31:01 2016 +0200
Merge pull request #2005 from rpv-tomsk/issue-1996
write_http: Fixed DS type check
commit a92b550961ed60b55f391ff073fbe005ba3c1f53
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date: Wed Oct 26 23:27:36 2016 +0600
write_http: Fixed DS type check
Closes: #1996
commit a9f509bacfda6be6882527a16563f260e4373246
Author: Florian Forster <octo at collectd.org>
Date: Wed Oct 26 17:09:17 2016 +0200
src/daemon/utils_time.h: Use composite literals in all macros.
This allows to take the address of all these macros. Unfortunately, this
means we require special macors for initializing static variables, but
fortunately this is not very commonly done.
commit a762b2b4a6d804139c9ab5f47afacc1a88d6c0c1
Author: Florian Forster <octo at collectd.org>
Date: Wed Oct 26 16:46:29 2016 +0200
src/daemon/utils_time.h: Return structs from CDTIME_T_TO_TIME{VAL,SPEC}.
Since these are macros use composite literals, you can even take the
address of these struct, which is very handy for calling nanosleep()
and friends.
commit 2ede5e7fd0f7e75edd1fba531cd870bb16092e71
Author: Florian Forster <octo at collectd.org>
Date: Wed Oct 26 09:31:47 2016 +0200
src/daemon/utils_cache.c: Refactor uc_check_timeout().
commit bf70b5ba18d3fc58f976f2923ecf7135900537a7
Merge: 92860d6 7d2981b
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Mon Oct 24 17:36:22 2016 +0200
Merge pull request #1997 from rpv-tomsk/issue-1995
powerdns plugin: Improved error reporting
commit 7d2981b4b3245d5ead2f3156a6b6c440691691cf
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date: Thu Oct 20 20:24:14 2016 +0600
powerdns plugin: Improved error reporting
Show socket path in log messages.
Closes: #1995
commit 92860d61218a3da1e9b74a2fad37e9df88df8ce8
Merge: 1e56870 b7c67e8
Author: Florian Forster <octo at collectd.org>
Date: Fri Oct 14 22:51:04 2016 +0200
Merge remote-tracking branch 'github/pr/1749'
commit 1e5687027549c68ecb29f33822501f6976debd5f
Merge: 08a5f15 6a4e409
Author: Florian Forster <octo at collectd.org>
Date: Wed Oct 12 16:57:19 2016 +0200
Merge branch 'pr/1609'
commit 6a4e409854a5322bed28347237a7614c59925e2a
Author: Florian Forster <octo at collectd.org>
Date: Wed Oct 12 16:56:58 2016 +0200
nginx plugin: Add comment, fix indentation.
Add a comment reminding us to remove the "handled" metric in a later
major release. Also fixes mixes tab/space indenting.
commit 5e4f2ae61dc39938c4df857854724ba1d36f3232
Author: Thomas Deutschmann <whissi at gentoo.org>
Date: Tue Oct 11 16:16:23 2016 +0200
common.c: Use _LINUX_CAPABILITY_VERSION_3 in cap_header
While check_capability() function already requires
_LINUX_CAPABILITY_VERSION_3 via "#ifdef" since commit 448627953c we still
set the cap_header's version to deprecated _LINUX_CAPABILITY_VERSION. This
results in a warning like
> capability: warning: `collectd' uses 32-bit capabilities (legacy support in use)
from the kernel when a plugin (like iptables) calls our check_capability()
function.
With this commit we will set cap_header to kernel's current capability
version (_LINUX_CAPABILITY_VERSION_3), which is default since
kernel 2.6.26.
Signed-off-by: Florian Forster <octo at collectd.org>
commit 08a5f153af9ec41dcb098034e836cb85ea940486
Merge: a5dc467 bb0000a
Author: Florian Forster <octo at collectd.org>
Date: Tue Oct 11 08:49:29 2016 +0200
Merge remote-tracking branch 'github/pr/1981'
commit a5dc46700b069994d91b92fb46c8b2c2a1468c34
Merge: 3a4ac4e 1805cef
Author: Florian Forster <octo at collectd.org>
Date: Tue Oct 11 08:36:15 2016 +0200
Merge remote-tracking branch 'github/pr/1980'
commit 3a4ac4e07fd870d0fc026fadd25f5fe5e2dda598
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Oct 10 21:04:20 2016 +0200
bind: fix 2 typos spotted by Debian's lintian tool
authorative -> authoritative
dupliate -> duplicate
Despite this mistake is also found in the collectd-5.5 and 5.6 lines,
the fix is scheduled for 5.7.0 because it will change 2 VL's
type_instances, possibly breaking users' dashboards or alerting.
commit 8c5927c52f4eefebaad3a6ecadc253ee9007ebb5
Merge: a35e7bb 9c962b9
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Oct 10 21:04:03 2016 +0200
Merge branch 'collectd-5.6'
commit 9c962b99a3acd77f1d6e2499052b47356819511a
Merge: a349e06 dd09c93
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Oct 10 20:58:19 2016 +0200
Merge branch 'collectd-5.5' into collectd-5.6
commit a349e06f0c4e2c853eced8a2621f52ee712b6e0c
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Oct 10 20:50:00 2016 +0200
fix one typo spotted by Debian's lintian tool
commit dd09c9364998ad6ef681b70f45f7a9734808cf96
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Oct 10 20:55:56 2016 +0200
fix a couple of typos spotted by Debian's lintian tool
commit 5a5ebb90e5f46b723eb4ceb39511cafc2dc25002
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Oct 10 20:47:30 2016 +0200
collectd.spec: increment changelog to mention 5.6.1
commit a35e7bb5ee1004f9631a9c4b9569b2cc00016ae5
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Oct 10 20:44:03 2016 +0200
collectd.spec: add new intel_rdt plugin
commit 1805cefd7f0cb4fb24209e4d0eb5fdf5daa6c414
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date: Mon Oct 10 10:33:28 2016 +0600
processes plugin: Do not gather processes IO and context switch data when unneeded
commit 4461e8978b928b4b4f78e1620c6f85135e2544cc
Author: Victor Demonchy <v.demonchy at criteo.com>
Date: Mon Oct 10 15:28:22 2016 +0200
Bump version number in redhat spec
commit bb0000acfc57e230fc1c26099bc7acb913680f1a
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date: Mon Oct 10 13:25:07 2016 +0600
processes plugin: Fix counters initialization / spikes
processes plugin generates spikes on (re)start. That is caused by
wrong counter logic: When collectd (re)started, monitored processes,
which was started before collectd, have non-zero values in
cpu_user/cpu_system/vmem_minflt/vmem_majflt, so `want_init` is false.
What produces spike.
At other hand, processes which are started between read cycles, should
be fully accounted without initialization. So, we must skip only first
cycle for these counters.
commit 14b4024e2e621b440f96e8f2ef1af04d6275ee34
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date: Mon Oct 10 13:07:55 2016 +0600
processes plugin: Remove unused fields from structures
Fields cpu_user, cpu_system, vmem_minflt, vmem_majflt are always equal to zero for new entries (which are passed to ps_list_add()).
Values of these fields are not used in `procstat_t` entries too. So, that can be safely removed.
commit c210d9ec19724d829d8744b35a7426837b76982e
Author: Pavel Rochnyack <pavel2000 at ngs.ru>
Date: Wed Mar 9 16:39:22 2016 +0600
nginx plugin: Report failed connections
commit 3933d0a0e2a8887b40c77ac0a92c1cac79f9b4a1
Merge: f8232cf df51d49
Author: Florian Forster <octo at collectd.org>
Date: Sat Oct 8 07:48:15 2016 +0200
Merge remote-tracking branch 'github/pr/1958' into collectd-5.5
commit 1f94db271df2d90ef771304d442a0decb9f6cd1c
Author: Florian Forster <octo at collectd.org>
Date: Fri Oct 7 15:52:00 2016 +0200
Bump version to 5.6.1; Update ChangeLog.
commit d0408cb0dbef15d739a6b1cd047e9c94d7643329
Merge: 8476eff f8232cf
Author: Florian Forster <octo at collectd.org>
Date: Fri Oct 7 08:51:29 2016 +0200
Merge branch 'collectd-5.5' into collectd-5.6
commit f8232cfe5e140b6c89dbe736480ae547a0e04374
Merge: f90895e a2e870f
Author: Florian Forster <octo at collectd.org>
Date: Fri Oct 7 08:44:53 2016 +0200
Merge remote-tracking branch 'github/pr/1961' into collectd-5.5
commit 8476effff293409ad4cb53d87af453ebbb61a064
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Tue Oct 4 23:46:45 2016 +0200
write_graphite: remove linking against libyajl (#1976)
write_graphite doesn't have anything to do with json. This seems to have
been accidentally added in 30c1111.
Fixes https://bugs.debian.org/839771
commit a2e870fa005e4612ed126a49fbebd8618e50da6f
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Sep 25 13:40:57 2016 +0200
Use readdir() instead of the deprecated readdir_r().
Cf. https://sourceware.org/ml/libc-alpha/2016-02/msg00093.html
commit b7c67e8ccfc70f52f8533df9502424de85074eee
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Sep 25 13:23:43 2016 +0200
Declare loop variable in the loop expression.
commit 77f3dd8deab5fe72d2e0d8620424b1f3bfdfdad7
Author: Sebastian Harl <sh at tokkee.org>
Date: Fri Jun 10 21:59:03 2016 +0200
valgrind.FreeBSD.suppress: Suppress bogus invalid read in all call chains.
commit 60bd99df46327b90854a638fac40766a823a818c
Author: Sebastian Harl <sh at tokkee.org>
Date: Fri Jun 10 20:50:04 2016 +0200
Link libcmds (used for testing) against -lm.
FreeBSD requires this for isfinite().
commit f5fdf24ccec9318baf11eec25d6dba881dc77332
Author: Sebastian Harl <sh at tokkee.org>
Date: Thu Jun 9 00:37:58 2016 +0200
command parser: Add support for parser options.
These can be used to tune the parser behavior. For now, there's an option to
specify the default hostname in an identifier.
commit 5bed427b409db41140d5799c979ee556dd66393d
Author: Sebastian Harl <sh at tokkee.org>
Date: Thu Jun 9 00:36:18 2016 +0200
parse_identifier: Make hostname optional, if a default has been specified.
commit 7535ee83bf0b12a168cee3c70e5fb97ed6dfc96c
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Jun 5 21:43:56 2016 +0200
utils_cmds_test: Add various unit tests for the command parser.
commit 96dcfa56e3e5bddb15531eb72279da1f4c551ac5
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Jun 5 21:41:39 2016 +0200
command parser: Set command type to UNKNOWN upon failure.
commit 87347b871a0bcf4e51046299ed0e59b151ef3c0b
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Jun 5 21:40:57 2016 +0200
PUTVAL command: Fix memory leaks and duplicate frees.
commit c8d05f9e0d747e1745b14984b98c551fa0c094e6
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Jun 5 21:40:13 2016 +0200
LISTVAL command: Add missing cmd_destroy_listval().
commit 6e6c1eecf05ac8bc9e59b0967cb87e578253d5a0
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Jun 5 18:39:36 2016 +0200
command parser: Add support for the GETVAL command.
Implement the generic interface for GETVAL and switch the GETVAL
implementation to use the generic interface.
commit 6108316e4008edce45c6d861b49e339c1360181f
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Jun 5 18:08:47 2016 +0200
command parser: Add support for the LISTVAL command.
Implement the generic interface for LISTVAL and switch the LISTVAL
implementation to use the generic interface.
commit 938471bee8cc86d32615144c5037f17338b19e70
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Jun 5 17:50:58 2016 +0200
command parser: Add support for the FLUSH command.
That is, implement the generic interface for FLUSH and switch the FLUSH
implementation to use the generic interface.
commit 7747e2ad9a86c2307094cd4ca3f753e46329c7a5
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Jun 5 16:44:39 2016 +0200
plugin.h: Introduce the identifier_t type with pointer fields.
This serves two purposes:
- Allow field values of arbitrary length.
- Reuse the identifier in other places.
Renamed identifier_t from utils_vl_lookup to lookup_identifier_t.
commit 1aa4295ba6875ceb02a7383237bc2485ffab9c1e
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Jun 5 15:23:41 2016 +0200
command parser: Add a vector-based interface.
The new interface expects a parsed list of fields. Parsing of input buffers
is now done centrally in the generic code and the existing parser is a
wrapper around this and the new vector-based parser. The actual command
parsers (PUTVAL for now) receive the parsed list of fields.
As a side-effect, this changes the parser behavior a little:
- "foo=a string with spaces or \\ special characters" is now valid syntax
for specifying options in addition to foo="value with spaces, etc.".
- foo= is now a valid option even without quotes around the empty value.
commit 3090a8852788aaca0d8063fdf9ac4ba66f048cd8
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Jun 5 13:59:49 2016 +0200
Add a generic interface for parsing the text protocol.
Implement it for PUTVAL for now.
The text protocol is used in multiple places and the parser will avoid code
duplication in client programs which can, instead, use it to generate the
respective requests.
Use the 'cmd_' prefix for public functions related to command handling.
commit f90895e424aee58b19cd497a650a4592658f60ad
Author: Sebastian Harl <sh at tokkee.org>
Date: Sat Sep 24 13:05:06 2016 +0200
RRDCacheD plugin: Improve various RRD-related error messages.
commit 5818b2e6cb1fe66746375885419e9c75134f8cb6
Author: Sebastian Harl <sh at tokkee.org>
Date: Sat Sep 24 12:55:40 2016 +0200
RRDCacheD plugin: Try to reconnect upon failed operations.
The RRD client library does not provide means to check the status of a
connection and there's no way to detect that the connection is broken after,
for example, the daemon restarted. To work around that, try to reconnect if
any client operation fails.
Reported via https://bugs.debian.org/657877
commit df51d4962c03fd646bb6e8be0d41d6e15ee0cad4
Author: Chao Yang <cyang244 at bloomberg.net>
Date: Fri Sep 23 10:48:53 2016 -0400
commom: Fixed AIX doesn't have MSG_DONTWAIT
commit f7b05ebf3311b4c6cb5289f1f7cd8ee02918ef92
Merge: 7df2428 0b97cf2
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Tue Sep 20 21:23:09 2016 +0200
Merge branch 'collectd-5.4' into collectd-5.5
commit 7df2428077e2001fdfab3ebbb3bb74b0491b74bd
Author: Florian Forster <octo at collectd.org>
Date: Wed Sep 14 09:00:00 2016 +0200
contrib/examples/myplugin.c: Fix copy and paste error.
commit 0b97cf2d91851a6892ff025c6775a59d98a8bada
Author: Bernd Zeimetz <bernd at bzed.de>
Date: Fri Sep 2 14:05:58 2016 +0200
Also fix query_plans_by_table
#1905 happens here obviously, too.
commit e73ae9a16ebf982dc5712a8e4f4d4f864187e08a
Author: Bernd Zeimetz <bernd at bzed.de>
Date: Fri Sep 2 13:23:40 2016 +0200
pgsql plugin: avoid parsing error from query_plans
idx_scan/idx_tup_fetch can be NULL, avoid trying to parse that into a number.
This should fix #1905.
commit 55826ee891fd643111c3ffd7a19795721e41f1c0
Author: Florian Forster <octo at collectd.org>
Date: Fri Sep 2 10:48:08 2016 +0200
src/common.c: parse_value: Quote string that failed to parse.
Issue: #1905
More information about the collectd-changes
mailing list