[collectd-changes] collectd, the system statistics collection daemon: Changes to 'collectd-5.4'
Florian Forster
octo at verplant.org
Fri Jan 22 10:53:38 CET 2016
configure.ac | 47 ++++++---
src/Makefile.am | 16 ++-
src/aggregation.c | 1 +
src/amqp.c | 6 +-
src/bind.c | 3 +-
src/collectd-tg.c | 1 +
src/collectd.conf.in | 2 +-
src/collectd.conf.pod | 39 +++++++-
src/common.c | 3 +
src/configfile.c | 9 +-
src/cpu.c | 28 ++++--
src/csv.c | 7 +-
src/curl_json.c | 109 ++++++++++-----------
src/curl_xml.c | 72 +++++++-------
src/df.c | 27 ++++-
src/email.c | 68 ++++++++-----
src/filecount.c | 1 +
src/filter_chain.c | 21 +---
src/gmond.c | 74 +++++++-------
src/iptables.c | 207 +++++++++++++++++++--------------------
src/irq.c | 1 +
src/libcollectdclient/client.c | 2 +
src/libcollectdclient/network.c | 25 +++--
src/libvirt.c | 4 +-
src/madwifi.c | 7 +-
src/meta_data.c | 2 +
src/modbus.c | 8 +-
src/multimeter.c | 9 +-
src/netapp.c | 2 +-
src/ntpd.c | 35 ++++---
src/openvpn.c | 12 ++-
src/perl.c | 14 ++-
src/pinba.c | 1 +
src/ping.c | 4 +-
src/postgresql.c | 14 +--
src/powerdns.c | 2 +-
src/processes.c | 3 +-
src/python.c | 71 ++++++++++----
src/rrdtool.c | 45 ++++++---
src/sigrok.c | 9 +-
src/snmp.c | 3 +-
src/statsd.c | 1 +
src/swap.c | 6 +-
src/table.c | 2 +-
src/tail.c | 12 ++-
src/teamspeak2.c | 1 +
src/threshold.c | 5 +-
src/unixsock.c | 11 ++-
src/users.c | 3 -
src/utils_cache.c | 3 +-
src/utils_fbhash.c | 5 +-
src/utils_format_json.c | 46 +++++----
src/utils_ignorelist.c | 111 +++++++++------------
src/utils_latency.c | 93 ++++++++++--------
src/utils_mount.c | 65 +++++++++++-
src/varnish.c | 4 +-
src/vmem.c | 13 +++
src/write_graphite.c | 2 +-
src/write_redis.c | 3 +-
59 files changed, 841 insertions(+), 559 deletions(-)
New commits:
commit 573db6cb7d8904468546746117efbd989d4a5843
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Jan 18 16:44:52 2016 +0100
df: remove legacy code skipping "rootfs" monitoring
3512bb1 added code to skip duplicate reporting of `rootfs` mounted on `/`.
f9c1c5b and f0398d0 added generic code to skip any volume mounted twice.
Depending on the order of the entries in `/etc/mtab`, reporting for `/` was
entirely skipped.
This patch basically reverts the first, non-generic patch, as it's
superseded by the 2 others.
Fixes #1402
Signed-off-by: Florian Forster <octo at collectd.org>
commit e68993d241360e8da64e1c1f2d8adb3bc7f67e34
Author: Jakub Jankowski <shasta at toxcorp.com>
Date: Thu Jan 21 21:43:26 2016 +0100
docs: Add info about mode7 requirement for ntpd
Since ntpd-4.2.7p230 "mode 7" requests are ignored by default, and
that's what ntpd plugin uses currently. The ntp daemon must be
explicitly configured to enable mode7 requests.
This patch adds short information about that to collectd.conf manpage.
Related to collectd/collectd#932
Signed-off-by: Jakub Jankowski <shasta at toxcorp.com>
commit 01bb122fca4bd5c767b795f9cff364d01f0573c3
Author: Jakub Jankowski <shasta at toxcorp.com>
Date: Thu Jan 21 17:15:20 2016 +0100
docs: mention regexps for the interface plugin
It is very useful to collect data (or ignore) from a group of interfaces
that are similarly named - especially if the list is dynamic and it's
not feasible to update configuration each time an interface shows up or
disappears. It's possible to use regexps to specify interfaces to
collect data from (or ignore), but it's not clearly stated anywhere in
the documentation.
This is an attempt to improve documentation in this area.
Signed-off-by: Jakub Jankowski <shasta at toxcorp.com>
commit 6e7993bf0377b60320a8a4112c5535b17a2a02c0
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 1 16:18:38 2015 +0100
exec plugin: Revert file mode to 0644.
This fixes a regression from 94e562250296b1435e3e48cd302055d89c4c702b.
commit 376667a354fe85443c5214e2039d71a13f4fdebd
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Wed Jan 20 09:47:31 2016 +0100
virt plugin: make indentation explicit
Fixes this warning raised by gcc-6's new "misleading-indentation"
option:
```
virt.c: In function 'lv_init':
virt.c:331:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
return 0;
^~~~~~
virt.c:328:5: note: ...this 'if' clause, but it is not
if (virInitialize () != 0)
^~
```
commit a8700539e4131ae20af1462d1e6c6ec38a266577
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Jan 18 17:49:24 2016 +0100
df: remove legacy references to ReportReserved
The ReportReserved option was removed in fcb3cbf. This patch cleans up a
couple of references which got left behind.
commit 63f8df381c3c7d5c349fdfb1f4ea1cf6ae40d521
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Nov 28 18:37:15 2015 +0100
write_redis: don't return with lock held
commit bc32fe6c76b13b96c4834768b8a8eab8943327dc
Author: Florian Forster <octo at collectd.org>
Date: Tue Jul 14 08:42:15 2015 +0200
src/utils_latency.c: Fix format string error.
commit c1e9222b1e9212d48b1ea38d886fc4a79fcd9625
Author: Florian Forster <octo at collectd.org>
Date: Tue Jul 14 08:34:52 2015 +0200
src/utils_latency.c: Ensure that LLONG_MAX is defined.
EPEL5 doesn't have it in <limits.h> apparently.
commit bf20109876505eddc2c741e87e96e7cb54af9efa
Author: Florian Forster <octo at collectd.org>
Date: Mon Jul 13 11:53:58 2015 +0200
src/utils_latency.c: Store "bin_width" as cdtime_t.
This solves the integer overflow when passing huge latency values to
latency_counter_add(). In addition to fixing the overflow the function
will now ignore values that are larger than LLONG_MAX, i.e. the longest
possible latency is 272 years. As a nice side-effect, the precission of
latency_counter_get_percentile() is improved.
Issue: #1131
commit e183a8d7e22298181bcf07529f04aed1568809fb
Author: Florian Forster <octo at collectd.org>
Date: Sun Jul 12 12:58:20 2015 +0200
src/utils_latency.c: Fix change_bin_width().
A missing cast when calculating "width_change_ratio" caused all metrics to
be moved to bucket #0.
commit ab94e78c24186f78b79f3a6fc624ce886adaa4b6
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Jul 4 22:49:49 2015 +0200
varnish: fix leak on read
Since VSM_Close doesn't free the object we leak a few bytes
every interval
commit b7f9a3c02d885e0fbe8fb7aac5c9a51b5771a9d3
Author: Florian Forster <octo at collectd.org>
Date: Fri Jun 19 16:26:12 2015 +0200
openvpn plugin: Fix "Dead assignment" warning.
commit 699ed6dd24817c046f47c2c5934d9af6343e4c65
Author: Florian Forster <octo at collectd.org>
Date: Thu Jun 18 16:45:23 2015 +0200
modbus plugin: Make sure variable is initialized.
This was introduced by the merge
(09c6a320f3cb36b5dbb2c2ce43858f33be7acf9b).
commit ebd643d6d564fc249cd42b130c4bbabd813ea6fd
Author: Florian Forster <octo at collectd.org>
Date: Thu Jun 18 15:31:11 2015 +0200
tail plugin: Make sure variable is initialized.
This was introduced by the merge
(09c6a320f3cb36b5dbb2c2ce43858f33be7acf9b).
commit 10e6e69a60f1722bb0a8a3b25bd5812471f33cfc
Author: Dagobert Michelsen <dam at opencsw.org>
Date: Thu Jun 4 13:25:48 2015 +0200
Fix header condition
The dependency is either UTMPX or UTMP or Statgrab. The inclusion above hasn't statgrab.h in the elif-chain, that means compilation fails when only libstatgrab is available. The line can safely be taken out as the same condition is checked in #L120.
commit 5d5e6749dde4cccc5616df8536775d0f237df5e9
Author: Claudius Zingerli <gitmail at zeuz.ch>
Date: Tue Jan 5 18:22:22 2016 +0100
Fixed rrdtool sigsegv (datadir==NULL ptr dereferencing)
commit 10f0577fddc1b8583f4eb0bb96efb3439140902f
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Wed Jan 13 09:12:23 2016 +0100
processes: correct a typo
commit bf4061d7f280863130619559c95badce90fb8444
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Nov 29 18:06:33 2015 +0100
perl: unlock mutex on error
CID 37970
commit 9c0fc91d5c2e28bd1d9f214bd479cafdd0b4b304
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Nov 29 18:27:56 2015 +0100
openvpn: free resource on error
commit 59c02f665ec32d3bec05e8e43129ee32db1bbae3
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Nov 29 18:23:17 2015 +0100
openvpn: fix error message
commit 39bfd94dd45dd8a20318cf8fd01da0b9467d5da6
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Nov 29 18:22:30 2015 +0100
openvpn: check return value of malloc
CID 37987
commit fb9883b5bcf5e40e2a32e47edf5561518adef0b1
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Nov 28 20:27:22 2015 +0100
curl_json: remove dead code
CID 37963
commit 3a2d7481341d647ca194861dc93d5f309d28e36b
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 19:31:16 2015 +0100
snmp plugin: don't read from uninitialized pointer
if the first snmp_pdu_create inside the loop returns an error,
we exit the loop with res uninitialized and then call snmp_free_pdu on it.
CID #38037
commit 84bf5e22635704f34a0d456ac3d2481ebe0e3672
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 19:02:32 2015 +0100
libcollectdclient: don't close socket twice
CID #38039
commit 951af13fcec781791beaff29ea76639a8ff166d9
Author: Ruben Kerkhof <ruben at tilaa.com>
Date: Sat Dec 12 12:24:41 2015 +0100
email plugin: fix check for result of malloc
CID #38010
commit d3f743a826c9718b29d32ac95c00a37b92f6672e
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Tue Jan 12 06:52:54 2016 +0100
collectd.conf.pod: mention IPv6 option to the iptables plugin
Thanks to @michaelsalmon for pointing this out !
Fix #1496
commit e4908c8c45e8c53bd510ed54ec0c89e0e52c5ead
Author: Laurent <laurent+git at u-picardie.fr>
Date: Wed Jan 6 10:52:31 2016 +0100
remove the addressof in the sizeof
quick fix for issue 1501?
the new warning for pointer access introduced in gcc 4.8 helped to find
this one.
commit 5a223866595c0d7eb032c3c4fc3c7cd148e59f99
Author: Florian Forster <octo at collectd.org>
Date: Thu Dec 17 15:13:39 2015 +0100
perl plugin: Check "return value" of PERL_GET_CONTEXT.
CID: 37985
commit bcdc88f3bf672862f7b78ddf27a1a890ee27cf6a
Author: Florian Forster <octo at collectd.org>
Date: Thu Dec 17 14:57:13 2015 +0100
email plugin: Don't call type_list_incr() with type == NULL.
CID: 37988
commit 1d0fac069a153a08c488c0eece2dc9c32b9394e9
Author: Florian Forster <octo at collectd.org>
Date: Thu Dec 17 14:25:19 2015 +0100
gmond plugin: Inline the plugin_dispatch_values() call.
Since version 5.3, a write queue is used. This means that the
plugin_dispatch_values() call will create a copy of the value list and
return quickly. Creating yet another copy here is therefore not as useful
anymore.
CID: 38114
commit 1c639d74e12ae6da05f93596478429c389246b4e
Author: Florian Forster <octo at collectd.org>
Date: Thu Dec 17 14:18:59 2015 +0100
gmond plugin: Check return value of sendto(2).
CID: 38113
commit 0ea11b520f610d0ed8fc34f50a7880c3c78c4186
Author: Florian Forster <octo at collectd.org>
Date: Thu Dec 17 14:21:27 2015 +0100
gmond plugin: Check return value of setsockopt(2).
CID: 38112
commit b1582672709204fd2342a50e1d25467d99568199
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 12 16:43:55 2015 +0100
configure.ac: warn when pkg-config is not installed
It hasn't been optional for a while now.
Fixes:
checking for rrd.h... no
./configure: 25157: Syntax error: word unexpected (expecting ")")
Signed-off-by: Florian Forster <octo at collectd.org>
commit 9fd3d670c4e85d840e618647c15b64d728a3f193
Author: Florian Forster <octo at collectd.org>
Date: Fri Dec 11 09:18:27 2015 +0100
src/utils_ignorelist.c: Refactoring / code style fixes.
One of the goals was to remove uses of smalloc().
commit 7368bf2a94337b18b67a0c3573ddb2d71534ae8d
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Thu Dec 10 19:38:04 2015 +0100
swap plugin: don't exit when malloc fails
Signed-off-by: Florian Forster <octo at collectd.org>
commit 76861053164f54a21651612daf89a30cca657184
Author: Florian Forster <octo at collectd.org>
Date: Wed Dec 9 09:44:24 2015 +0100
curl_json plugin: Rewrite logic to add a path to db->tree.
CID: 37991
commit af65708633988a33dd9e50e12f20dc8e21af4588
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 16:56:52 2015 +0100
curl_xml plugin: Correctly free xpath object.
CID: 37993
Signed-off-by: Florian Forster <octo at collectd.org>
commit dc0e64a5811fe065ca88b5c973f4db0dd6f1355f
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 14:38:05 2015 +0100
ping plugin: Protect access to ping_thread_error.
This is primarily to make Coverity happy.
CID: 37976
commit 86c6d276d13dc97c875ee363219bee744529cddc
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 14:31:33 2015 +0100
ping plugin: Remove "static" from local variable.
This caused Coverity to see concurrency issues where there are none.
CID: 37934
commit 4ef7c074cdbab9c43cbbfcb918e9ba4f6be6fa1e
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 14:22:54 2015 +0100
rrdtool plugin: Improve handling of the "DataDir" option.
CID: 37977
commit 07f6de709d9aa0d8e3b5bf888a10bb8efdfdc6f4
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 13:54:17 2015 +0100
python plugin: Check return value of cpy_unicode_or_bytes_to_string().
CID: 37984
commit acee3e5ef13384b24d83da25a12f72e4e32c60ab
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 13:44:28 2015 +0100
python plugin: Check return value of malloc().
CID: 37981, 37982, 37983
commit 3e413a72f2387d600fa00169823c7ce0d0b649b5
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 13:41:35 2015 +0100
python plugin: Fix memory leak.
The regiser_read / register_write functions assume a user_data_t*
pointing to static memory and will not store / free the pointer.
CID: 38002
commit e3571ad6e1ada10fb7220193df57b7ef3b540ab1
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 13:14:47 2015 +0100
tail plugin: Fix memory leak.
CID: 38013
commit 456d6b6b5f855b588eaef23b26e5b91d14586cc5
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 13:07:26 2015 +0100
postgresql plugin: Register a new user data pointer with udb_query_set_user_data() unconditionally.
CID: 38019
commit 0672b1d3b0c914d54191a7ca203d02061792a9bd
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 12:51:29 2015 +0100
email plugin: Refactor the accept() loop.
This removes the assumption that accept() returning a socket (success)
implies that errno is not equal to EINTR. This is probably a reasonable
assumption, but trips up Coverity may be a bit hard to read.
CID: 38009
commit 77425c1a1afd89f17171281665ccbf0172b3da42
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 11:56:09 2015 +0100
email plugin: Free "connection" in error handling.
CID: 38010
commit ac7b4bd56283ba970c15fadaff15a4dad96fbf69
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 11:49:56 2015 +0100
postgresql plugin: Remove invalid free().
CID: 37936
commit 3bca8a6cdbb7d6d25489eaf13ac1387c257ae681
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 11:46:09 2015 +0100
src/collectd-tg.c: Explicitly null-terminate string.
CID: 37937
Signed-off-by: Florian Forster <octo at collectd.org>
commit 3ec8f4d3d019658e3047855b6b71436b60c6a3b4
Author: Florian Forster <octo at collectd.org>
Date: Tue Dec 8 11:30:13 2015 +0100
src/utils_format_json.c: Make sure "keys" is freed in all error paths.
CID: 38008
commit 5997c2158f5712e4b67be142726b6a627582cc78
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Dec 6 12:09:20 2015 +0100
sigrok plugin: don't pass status to strerror
CID #38120
Signed-off-by: Florian Forster <octo at collectd.org>
commit 00f7d2c68690ee66bf8729a9150835faa8b8730a
Author: Florian Forster <octo at collectd.org>
Date: Sat Dec 5 23:37:16 2015 +0100
multimeter plugin: Initizliaze "struct termios".
CID: 38036
commit b1cad5912a658356bdcb49aa208e15307b3a61a0
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 22:17:43 2015 +0100
configure.ac: fix previous change to detect libjvm
This worked on OSX but failed on Linux.
Signed-off-by: Florian Forster <octo at collectd.org>
commit ac8f02ab4f25a6b62ec763a74442ae2d65450679
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 14:20:29 2015 +0100
meta_data.c: check return value of md_entry_alloc
CID #37986
Signed-off-by: Florian Forster <octo at collectd.org>
commit 7462900ca1749634a7fa9325c2e71f49e13d0095
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 15:07:40 2015 +0100
iptables plugin: remove dead code
ip version is either IPv4 or IPv6
CID #37962
Signed-off-by: Florian Forster <octo at collectd.org>
commit dd13cefb6c5b9d19bf7191d64389e704612367d4
Author: Florian Forster <octo at collectd.org>
Date: Sat Dec 5 22:49:05 2015 +0100
src/filter_chain.c: Refactor fc_process_chain() a wee bit.
commit cc00aef9aff0f52961c297b24cdea2c3b69782d9
Author: Florian Forster <octo at collectd.org>
Date: Sat Dec 5 22:48:18 2015 +0100
src/filter_chain.c: Delete dead code.
CID: 37961
commit c9c3f6489d993187844917190df4d7499120bec6
Author: Florian Forster <octo at collectd.org>
Date: Sat Dec 5 22:30:39 2015 +0100
src/common.c: Check arguments of parse_values().
CID: 37965
commit f3e1b0e73ce355fc74e823c1123e2d50efb49176
Author: Florian Forster <octo at collectd.org>
Date: Sat Dec 5 22:23:05 2015 +0100
libcollectdclient: Check return value of setsockopt().
Coverity CID 37944.
Signed-off-by: Florian Forster <octo at collectd.org>
commit 4d04d3b7e32b8777f7c7b04110b74194b991fbea
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 15:50:46 2015 +0100
configure.ac: fix libjvm detection on OSX
Shared libraries have the extension .dylib instead of .so
Ideally we look at shrext_cmds from libtool to find the shared library
extension but this works too.
Signed-off-by: Florian Forster <octo at collectd.org>
commit 386f05a78c939ca88cb96bee8df9a2f9fdee967d
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 15:16:36 2015 +0100
unixsock: check return value of chmod
CID #37948
Signed-off-by: Florian Forster <octo at collectd.org>
commit 5e29722923189425ce9f8a04f92055e3476cc648
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 14:09:12 2015 +0100
bind plugin: plug small leak
CID #37992
Signed-off-by: Florian Forster <octo at collectd.org>
commit a2c425d3a1669c6baf06ba27ce2008122fb0ed16
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 14:03:58 2015 +0100
curl_xml plugin: plug a few leaks on error
CID #37993
Signed-off-by: Florian Forster <octo at collectd.org>
commit 93f38a8c5cf4e9e870872bd7b5c9011af0e2a751
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 13:42:33 2015 +0100
stats plugin: close fd on error
CID #37995
Signed-off-by: Florian Forster <octo at collectd.org>
commit e1bc245ae043eab39888d87a953ee86973839e11
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 13:39:03 2015 +0100
utils_cache.c: plug leak on error
CID #38000
Signed-off-by: Florian Forster <octo at collectd.org>
commit 7806744084eddcbe7b7f7ffa46650e9e553db3d0
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 13:33:54 2015 +0100
Aggregration plugin: plug leak on error
CID #38005
Signed-off-by: Florian Forster <octo at collectd.org>
commit ce65e9a3072aff269b2caf29e7f1450a10882aba
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 13:21:25 2015 +0100
varnish plugin: fix two resource leaks on error
CID #42774
Signed-off-by: Florian Forster <octo at collectd.org>
commit 5b392ea020897afbc546274e6a6c64802ccfe546
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Dec 5 12:09:00 2015 +0100
libcollectdclient: free result of getaddrinfo
CID #37997
Signed-off-by: Florian Forster <octo at collectd.org>
commit 51f407eeaf373508098a06b9e352b7ed794d6335
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 21:03:44 2015 +0100
madwifi: make code a little bit clearer
buf2 is initialized to zero, readlink
will write at most sizeof(buf2) -1 bytes,
so the trailing null should not be overwritten.
Coverity doesn't see that, rewrite the code
differently so it does.
CID #38027
Signed-off-by: Florian Forster <octo at collectd.org>
commit df6d9bfc1b24ecf4ebd1c86a57fc39f3b25abbb2
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 23:21:31 2015 +0100
Pinba plugin: close fd on error
CID #38001
Signed-off-by: Florian Forster <octo at collectd.org>
commit 9758016d4d7ba5bcd74bd16f04ea8c98ca45c533
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 23:14:06 2015 +0100
configfile.c: close dir on error
CID #38006
Signed-off-by: Florian Forster <octo at collectd.org>
commit 0156c3098b39c4b7996891ec8342ed9c3f6d4aaa
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 22:02:29 2015 +0100
utils_fbhash.c: fix resource leak on error
CID #38014
Signed-off-by: Florian Forster <octo at collectd.org>
commit b8913bc047474aa0a3bfbf03ecbb3b5050605ed1
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 21:56:40 2015 +0100
multimeter plugin: fix fd leak
If open returns 0 we leak fd.
CID #38016
Signed-off-by: Florian Forster <octo at collectd.org>
commit e61246f70a8e81b034db36f2dd20ea0086198808
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 21:40:16 2015 +0100
postgresql plugin: don't exit on malloc failure
Signed-off-by: Florian Forster <octo at collectd.org>
commit 84c3e994c70aebb5ed1882a1f9cb2bfa6f64d39d
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 21:30:14 2015 +0100
perl: Check for NULL before dereferencing
CID #38023
Signed-off-by: Florian Forster <octo at collectd.org>
commit 6a69ca987e1c3774428c9ab2778624ee80f343c6
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 21:22:42 2015 +0100
table plugin: fix check for realloc
We were checking the wrong thing.
CID #38024
Signed-off-by: Florian Forster <octo at collectd.org>
commit 27a47fc62d90a115d7a00753a06ffab71e92f487
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 21:18:27 2015 +0100
utils_mount.c: check for null before dereferencing
CID #38025
Signed-off-by: Florian Forster <octo at collectd.org>
commit be7860449c290ec30458a514d36f3bee2a56991b
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Dec 4 19:09:28 2015 +0100
teamspeak2: fix potential use after close
If connecting to the last host fails, we exit the loop
with a closed fd, which we try to fdopen() later on.
CID #38038
Signed-off-by: Florian Forster <octo at collectd.org>
commit 74fa9577b1acbb965488aa0a48c140d8ece437bf
Author: Michael Salmon <michael.salmon at ericsson.com>
Date: Thu Jul 16 09:05:54 2015 +0200
threshold plugin: Register callbacks only once.
Fixes: #551
Signed-off-by: Florian Forster <octo at collectd.org>
commit f0398d0364bc5819471138f646cea6926a0c40bc
Author: Florian Forster <octo at collectd.org>
Date: Fri Dec 4 17:18:24 2015 +0100
df plugin: Fix the duplicate detection.
Not that multiple devices could be mounted at the same mount point ... I think.
Fixes: #1402
commit f9c1c5b6c37347d0177f42ad4457b1586b8912cd
Author: Stefan Brüns <stefan.bruens at rwth-aachen.de>
Date: Mon Aug 1 11:50:52 2011 +0000
df plugin: skip duplicate entries, fixes "uc_update: Value too old" error
Issue: #1402
commit 232a9073693ec24d25e3c8caa348af051495a3fa
Author: Jakub Jankowski <shastah>
Date: Thu Oct 15 23:30:33 2015 +0000
vmem plugin: Fix pgsteal for newer Linux kernels.
Fixes: #1307
commit 51fff4e3791f0a85222be3659884b5ab9acc3116
Author: Manuel Luis SanmartÃn Rozada <manuel.luis at gmail.com>
Date: Sat Feb 8 21:30:21 2014 +0100
Link collectd-tg with pthreads
Signed-off-by: Florian Forster <octo at collectd.org>
commit 032cea5c9a5335f497e3e5a5784672a5a4aa0d49
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Nov 28 23:17:59 2015 +0100
irq plugin: close file descriptor on failure
CID 38018
commit c4f8a4d9a7ab23039a66c72c34fcab33e89b7592
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Nov 28 23:07:31 2015 +0100
modbus plugin: fix 2 leaks on error paths
commit 9c9a53b10ead3ee8103f625ed47066df2c9d5b87
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Nov 28 23:13:01 2015 +0100
filecount plugin: fix leak on error path
commit 9204a08464154faaca89690ad205989c121335cb
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Nov 28 19:45:42 2015 +0100
bind: tmp doesn't point to start of allocated memory
commit 58a503a9659c95813d0eb09382e3478b242f2de8
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Nov 28 18:48:20 2015 +0100
amqp: use the right buffer size for sstrncpy
buffer is a char *, not an array, so size_of returns the size
of the pointer.
commit 400f90a041f724c3e7b65d01560a0098d1cf9be7
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Nov 28 18:30:58 2015 +0100
powerdns plugin: fix array initialization
commit d4829955e302c8a9547a9019dda72ab59e0a64a9
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Nov 28 14:54:54 2015 +0100
Fix build with older version of libprotobuf-c
commit c06b91ff996f55eac5da78a6a6c9784b636c4b2f
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Tue Aug 4 15:40:34 2015 +0200
gcrypt: take search path into account
commit 81129cd1e8e25da49585ed2fb9781fa3606457f0
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Tue Aug 4 15:28:03 2015 +0200
gcrypt: remove exec-prefix check
libgcrypt-config --libs already includes the correct library include path.
Also, we hardcoded it to $exec-prefix/lib, which is just plain wrong on
64bit architectures.
commit 96c98c5ba38261a40b0592b81269bc89cbe97363
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 9 19:05:25 2015 +0200
protoc: check for headers in new location as well
Newer versions of protobuf-c have their headers in
/usr/include/protobuf-c, and a symlink from
/usr/include/google/protobuf-c/.
These symlinks will eventually disappear however, so be prepared.
commit 22f79bfb91033789ac305f261475f527fe3d8c19
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 9 19:02:25 2015 +0200
protoc: check for libprotobuf-c as well
commit 01902ff138552f2eee0a50fedfccdf4443ca8b4f
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 9 18:28:30 2015 +0200
protoc: simplify configure check
commit db3ffa2d2556ae9c8e5079dc93a43f9f5a02e3b2
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 9 17:23:11 2015 +0200
protoc: slightly nicer output in silent mode
make[1]: Entering directory '/home/ruben/src/collectd/src'
PROTOC-C pinba.pb-c.c
PROTOC-C riemann.pb-c.c
commit 82f38bbf606d19165657a522a691298253fd6366
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 9 17:02:33 2015 +0200
protoc: log when compiler is missing
In the case where we do have the required headers
but don't have the compiler, this makes it more clear
that we're missing the latter.
commit 36d4680ddbd5629badccb4448d053190ac5a3175
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 9 16:09:57 2015 +0200
Silence protoc-c in silence mode
Instead of showing the full command line, this shows:
GEN pinba.pb-c.c
GEN riemann.pb-c.c
commit f9eeaf81f7c87f081fd14d4369e0fc9ae6c6726b
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 9 15:52:33 2015 +0200
write_riemann: only compile .proto files when enabled
If the write_riemann plugin is not enabled there's no
need to compile the protobuf files.
commit 97776531522070ba8c9f1c92b53e8718533c2d40
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 9 15:50:55 2015 +0200
Pinba: only compile .proto files when enabled
If the pinba plugin is not enabled there's no
need to compile the protobuf files.
commit 20f29799747d983f74feec56cd48c408e3314770
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Jul 25 15:21:52 2015 +0200
utils_mount: use reentrant getmntent_r when we can
Fixes #1162
commit d4da90228a3f5c88ee8dca60d6f40fcf9c373058
Author: Florian Forster <octo at collectd.org>
Date: Mon Nov 30 20:02:23 2015 +0100
ntp plugin: Unify casting to gauge_t.
Also add note about STA_NANO.
Issue: #1314.
commit 53438c510bc06ca4ca0e12e41dc8c77c8dde5345
Author: Pierre Fersing <pierre.fersing at bleemeo.com>
Date: Tue Oct 20 11:27:41 2015 +0200
Fix NTP kerninfo offset/estimated error scaling
commit c334d63f821c5390af86b90c30e5334b2e97c6ad
Author: Florian Forster <octo at collectd.org>
Date: Mon Nov 30 13:31:49 2015 +0100
cpu plugin: Improve error message for host_processors() failing.
Issue: #22
commit b78ed0cf5d6be5def5e3ea9287ffa1e785558d81
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Nov 29 16:40:50 2015 +0100
rrdtool: unlock mutex on error
CID 37972
Signed-off-by: Florian Forster <octo at collectd.org>
commit ab2e3c958d3fed41438a8b3c2d0cca21b1bca56f
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Nov 28 20:19:26 2015 +0100
csv plugin: plug memory leak on error
CID 38015
Signed-off-by: Florian Forster <octo at collectd.org>
commit 65b7501893c7c828800ad4595274398c321511e1
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Nov 29 18:14:28 2015 +0100
rrdtool: release another lock on error
CID 37973
Signed-off-by: Florian Forster <octo at collectd.org>
commit ea4e6f8f62e5ec51b95387d1d111476468f8a7b1
Author: Sam Pointer <sampointer>
Date: Wed Nov 25 15:43:07 2015 +0000
the swrite interface is 'non-zero'
Signed-off-by: Florian Forster <octo at collectd.org>
commit 16fde0c303ae0afb7c945a78341c09df27c5cdbc
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Nov 27 22:14:08 2015 +0100
snmp plugin: plug leak in error path.
Partial back port of #1368.
Signed-off-by: Florian Forster <octo at collectd.org>
commit e01209268a710341765879eb32412027fb60257d
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Nov 27 22:00:10 2015 +0100
processes.c: plug memory leak in error path
Found with Infer (http://fbinfer.com/)
Signed-off-by: Florian Forster <octo at collectd.org>
More information about the collectd-changes
mailing list