[collectd-changes] collectd, the system statistics collection daemon: Changes to 'collectd-5.4'
Florian Forster
octo at verplant.org
Fri Nov 27 07:43:30 CET 2015
Makefile.am | 8 ++++-
configure.ac | 64 +++++++++++++++++++++----------------
contrib/collectd2html.pl | 2 +-
src/Makefile.am | 1 +
src/apache.c | 29 +++++------------
src/apcups.c | 10 +++---
src/collectd-exec.pod | 4 +--
src/collectd-nagios.c | 9 +++---
src/collectd.c | 4 ++-
src/collectd.conf.pod | 6 ++--
src/common.c | 16 ++++++++++
src/configfile.c | 5 ++-
src/dns.c | 1 -
src/exec.c | 78 +++++++++++++++++++++++++++-------------------
src/gmond.c | 1 +
src/iptables.c | 2 ++
src/irq.c | 4 +++
src/liboconfig/scanner.l | 9 ++----
src/memcached.c | 1 +
src/meta_data.c | 1 -
src/modbus.c | 2 +-
src/pf.c | 3 ++
src/plugin.c | 23 ++++++++------
src/processes.c | 22 ++++++-------
src/python.c | 5 +--
src/routeros.c | 2 +-
src/snmp.c | 5 ++-
src/statsd.c | 17 ++++++++--
src/utils_avltree.c | 1 +
src/utils_cache.c | 1 +
src/utils_vl_lookup.c | 5 +--
src/write_redis.c | 1 -
32 files changed, 200 insertions(+), 142 deletions(-)
New commits:
commit 007d96fe10beb6c6d4f20c79851404be18a3418f
Author: Corey Kosak <kosak at google.com>
Date: Wed Nov 25 16:54:30 2015 -0500
c_avl_pick needs to update the 'size' field of the tree when it deletes
a node.
Signed-off-by: Florian Forster <octo at collectd.org>
commit b2c062a99993e705dabd439a2a9c664960660ae9
Author: Corey Kosak <kosak at google.com>
Date: Wed Nov 25 17:03:47 2015 -0500
Remove duplicate call to pthread_mutex_destroy.
commit 4a16427cc827e7be32c4ed672a17bbb7cade284b
Author: Florian Forster <octo at collectd.org>
Date: Wed Nov 25 11:51:04 2015 +0100
statsd plugin: Correctly free metrics at shutdown.
The previous shutdown handler leaked "timer" and "set" metrics. This is
not a huge problem in itself, as the daemon is exiting shortly after
anyway, but it makes debugging of memory leaks very hard.
Issue: #997
commit c68a61a08267319ebfeddd372ab16124c592b288
Author: Florian Forster <octo at collectd.org>
Date: Fri Nov 20 11:01:38 2015 +0100
apache plugin: DRY: use macro to determine number of fields.
commit 50b1910527d68190c2d23dfc42759c917bcd3b1a
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Sun Nov 15 11:49:06 2015 +0100
apache: parse whole response, not only the first 16 lines
mod_status recently started reporting more statistics. According to
http://www.apache.org/dist/httpd/CHANGES_2.4 `mod_proxy, mod_ssl,
mod_cache_socache, mod_socache_*: Support machine readable server-status
produced when using the "?auto" query string.` for version 2.4.13
onwards.
As we can't assume everything we need will be included in the first 16
lines of output anymore, we now simply scan through the whole output.
commit de6a0cf70cf56af705d63bdc02e9c9d0dfb14b21
Author: Tamás Földesi <tamas.foldesi at more.no>
Date: Wed Jul 8 17:02:14 2015 +0200
Remove POLLRDNORM (equivalent to POLLIN)
commit 42a62db99c96d77fd6dc676b76705d8d90156c23
Author: Tamás Földesi <tamas.foldesi at more.no>
Date: Tue Jun 30 19:06:28 2015 +0200
Checking for closed peer connection before send
commit 6784becb0cecf1faf313ffb8da283acc416dc083
Author: Nathan Ward <nathan at primoris.co.nz>
Date: Thu Oct 29 14:22:44 2015 +1300
Fix clang complaining about extraneous parenthesis.
commit 30e6ef696754de41c6dd9f28afb1c17937a2efc2
Author: Nathan Ward <nathan at primoris.co.nz>
Date: Thu Oct 29 01:46:29 2015 +1300
ASN_GAUGE (SNMP-SMIv2 Gauge32) is unsigned, not signed.
commit b888aac60926d5d31af6a87a2a86ba02da032ad3
Author: Jan Andres <jan.andres at berenberg.de>
Date: Wed Oct 21 13:50:43 2015 +0200
Start write threads after plugin initialization.
Some plugins such as "network" create own threads from within their
init callbacks which can then start submitting data to the queue
right away, even if the read threads haven't been started yet.
If write threads are started before plugin initialization, this can
result in a race where a plugin's write callback gets called before
that plugin's init callback has completed.
To fix this, delay starting the write threads until after all plugins
have been initialized.
commit cf872835b60a3ec683b428832fbc79d6aa2df939
Author: Pierre-Yves Ritschard <pyr at spootnik.org>
Date: Mon Oct 19 11:53:26 2015 +0200
statsd: provide a gauge for counters, holding the absolute count.
When not using StoreRates false, this allows statsd aggregators
to hold on to the absolute count, if needed.
commit 644ce4666c420832fc76d219784d4e698d26829d
Author: Sergey <a_s_y at sama.ru>
Date: Tue Nov 3 07:19:50 2015 +0100
apcups: prefix plugin name in INFO and DEBUG statements
Fixes #1329
commit 8d8c82f9537feb8f15f049f3b1c071eaf2f5e2a5
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Tue Oct 27 23:32:20 2015 +0100
write_redis: remove unused variable from wr_write()
commit 62cd22cf3137251b30b3aa32e1abc4f95a0650f8
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Fri Oct 23 15:56:58 2015 +0200
collectd.conf.pod: correct a small typo
commit f8de611986ecf2fd6f1108c6511480e8deaee21f
Author: Douglas Thrift <douglaswth at gmail.com>
Date: Tue Oct 20 16:19:02 2015 -0700
Fix a few typos in collectd-exec(5)
commit 15eefc2d997debe27ac73cc46709fcb146f9b919
Author: Herve COMMOWICK <herve.commowick at adobe.com>
Date: Wed Oct 14 08:57:05 2015 +0200
processes: correctly count processes on FreeBSD
because actually we count threads instead of processes
(partial backport of 85c31a6d66 for collectd-5.4 /mf)
commit d1640328eb04352b0e486f6e6380e88c7be4cb50
Author: Sven Trenkel <collectd at semidefinite.de>
Date: Sun Oct 4 00:05:24 2015 +0000
python: Fix double-free bug.
commit 1a0ffe992fa7a970346fafb5f688fce5ee6f22ee
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Sep 14 00:03:44 2015 +0200
gmond: fix linking against libganglia at build time
Current versions of libganglia don't ship the ganglia-config utility
anymore. Change the configure script to not expect it to be in $PATH and
provide sensible defaults instead.
Fix #1129
commit 600c8b6ab8077ba5e871591bf55276f705fe520a
Author: Ruben Kerkhof <ruben at tilaa.com>
Date: Sat Aug 1 19:03:34 2015 +0200
mysql: use mysql_config --include for include path
According to the mysql_config manpage, --cflags shows the
compiler flags the library was compiled with. We certainly don't
want to use those.
commit 412a434094fb5ef130b026962945ca5168bb4036
Author: Ruben Kerkhof <ruben at tilaa.com>
Date: Sat Aug 1 19:02:15 2015 +0200
mysql: just search for mysql_get_server_version
If we found that symbol, assume we also found mysql_init.
commit da929b45f8df16dde909b2b884fcfbd3da7a0829
Author: Ruben Kerkhof <ruben at tilaa.com>
Date: Sat Aug 1 18:59:53 2015 +0200
mysql: respect mysql_libs when searching for symbol
We always looked in libmysqlclient, but this doesn't
work for compatible databases such as Percona.
Respect the list return by mysql_config --libs_r instead.
Fixes #1098
commit 3e4e90b633c79d398d7c10ec98463f3429f57aef
Author: Denys Berkovskyy <berkovskyy at gmail.com>
Date: Tue Sep 8 11:38:18 2015 +0100
Fix copy-paste error in debug message in snmp plugin
commit 9ab0a540f2b0f2b0427c33e198ca06d60d959182
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Fri Aug 14 22:25:20 2015 +0200
Fix harmless build warnings with newer binutils
I see a lot of those on Rawhide:
ar: `u' modifier ignored since `D' is the default (see `U')
It's going to take a while to get this fixed upstream.
Meanwhile, silence the warnings.
Macro copied from libvirt.
commit 4cee263e4f6a1cc0cf98f8f30f1687e99dcc74b5
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 16 12:28:43 2015 +0200
liboconfig: Fix implicit declaration warning
strlen declaration is in string.h
commit a5218a7626e9d1800f13d6580c708833bc62469f
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 16 13:47:24 2015 +0200
Don't unlock lock twice
Fixes make check on OpenBSD
commit 79032bd1b8aaa9cb0820a4105cfe2b070d4e6162
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 16 14:39:23 2015 +0200
pf: fix compilation on OpenBSD
commit f5b909a46905cf6ea1311293b439af6d985caa00
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 16 15:07:03 2015 +0200
dns: fix compilation on OpenBSD
OpenBSD doesn't have pcap-bpf.h
pcap.h has been including pcap/bpf.h since 2006.
Since we require a pcap which has PCAP_ERROR_IFACE_NOT_UP, introduced in 2008
this shouldn't break anything.
commit dbbafde7fae63b442786772c93144c2503976ead
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Wed Aug 26 23:28:50 2015 +0200
coding style fixes over 94e5622
commit 94e562250296b1435e3e48cd302055d89c4c702b
Author: Gautam BT <gautambt at gmail.com>
Date: Mon Feb 9 16:31:24 2015 +0530
Fix pipe leak in exec plugin
Fixes #762
commit 2a8e9257dece8803f559ab54f050b356bda86e66
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 9 19:46:08 2015 +0200
ltdl: only compile included libltdl when needed
If configure finds an external libltdl, it's going to
use it, so there's no use in compiling the shipped libltdl.
commit 4cfce925daf8e81c96c5bca630674f5e1f824067
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Wed Aug 5 18:05:02 2015 +0200
routeros: fix a small build error pointed out by clang
routeros.c:334:35: error: 'memset' call operates on objects of type 'cr_data_t' (aka 'struct cr_data_s') while the size is based on a different type 'cr_data_t *' (aka 'struct cr_data_s *') [-Werror,-Wsizeof-pointer-memaccess]
memset (router_data, 0, sizeof (router_data));
~~~~~~~~~~~ ^~~~~~~~~~~
routeros.c:334:35: note: did you mean to dereference the argument to 'sizeof' (and multiply it by the number of elements)?
memset (router_data, 0, sizeof (router_data));
^~~~~~~~~~~
commit 57e055803ca05d6aebfcce3132f609e07ccdd5fc
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Tue Aug 4 18:39:33 2015 +0200
Revert "amqp: look for librabbitmq in /usr/local as well"
This reverts commit c1c5087fd5d9e66427cee8c98c523519d578bee6.
... as a follow-up to the discussion which took place in #1201
commit 6124da7a48f28f54fc09ebeb942d1037516fe6ab
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Aug 1 11:46:45 2015 +0200
Fix libmodbus detection on FreeBSD
We look for modbus/modbus.h in /usr/local/include/modbus
but we should look for modbus.h
This is only an issue on FreeBSD since /usr/local/include is not
in the default search path.
commit c1c5087fd5d9e66427cee8c98c523519d578bee6
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Aug 1 13:01:30 2015 +0200
amqp: look for librabbitmq in /usr/local as well
This detects it automatically on FreeBSD.
Ideally we should just use pkg-config but that is
left as an exercise for the reader ;)
commit 91fbf283d2c180105c4729907ea9d2079c6d93f7
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sun Aug 2 20:54:51 2015 +0200
irq: skip FIQ line in /proc/interrupts
/proc/interrupts on my Raspberry PI contains:
FIQ: usb_fiq
This line doesn't contain any per cpu counters
but we try to parse it anyway, resulting in:
parse_value: Failed to parse string as derive: usb_fiq.
Fixes #971
commit d089d2691a24a1d9bdbb02e350405843c808d2bc
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Jul 25 12:32:06 2015 +0200
Fix a memory leak on shutdown
commit ec641aeb851d34295e8453d40596759039787339
Author: Shahul Hameed <skhajamohid1 at bloomberg.net>
Date: Mon Jul 20 13:06:23 2015 -0400
Add utils_parse_option.c/h to amqp plugin source files list
commit 51f45d6b217b1df976bd16593d293e4cea63ada9
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Jul 25 11:57:12 2015 +0200
collectd -T: fix memory leak
commit 00b6ce0313875d10ad0969a4c0169df0cddd8183
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Jul 25 19:17:07 2015 +0200
Fix some small leaks on error paths
commit 24667b83fc74c9ee4f0b7b89124c7be95774511a
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Jul 25 21:29:50 2015 +0200
liboconfig: really fix lex warnings
Flex has two options to disable input and unput.
Turn them on.
commit 57d95740f47c862be0c08841fecf28aeb97ecb94
Author: Florian Forster <octo at collectd.org>
Date: Fri Jul 10 11:29:45 2015 +0200
Revert "fix leak on exit"
This reverts commit 35e6b9d366016300178a55b163ac0173d7be5874.
commit 35e6b9d366016300178a55b163ac0173d7be5874
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Jul 4 20:02:57 2015 +0200
fix leak on exit
commit b157e863b19a5733919809f1bb860e5f316453c1
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Jul 4 19:56:20 2015 +0200
plugin.c: plug leak on error
commit 76c004d1db50ddee0be1f73f37c23afbe44f8bfc
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Jul 4 19:54:49 2015 +0200
memcached: plug leak
commit 26a4e6f1dd6bbae51fce89f3440785c9c06a77b8
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Sat Jul 4 17:35:03 2015 +0200
gmond: plug a small leak on exit
commit 999223e79a3b62e12569e3b7f80579d74938c90a
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Thu Jul 9 00:07:36 2015 +0200
collectd.conf.pod: correct a tiny typo
commit 18159adcefb255db5a5234a8476e703deb6cc09f
Author: Ruud van Melick <ruud at vanmelick.com>
Date: Tue Jun 30 16:08:49 2015 +0000
Fix Perl errors
"my" variable $cmd masks earlier declaration in same scope at /tmp/contrib_collectd2html.pl line 223.
syntax error at /tmp/contrib_collectd2html.pl line 219, near "$span qw(1hour 1day 1week 1month)"
Global symbol "$span" requires explicit package name at /tmp/contrib_collectd2html.pl line 221.
Global symbol "$span" requires explicit package name at /tmp/contrib_collectd2html.pl line 224.
Global symbol "$span" requires explicit package name at /tmp/contrib_collectd2html.pl line 225.
Global symbol "$span" requires explicit package name at /tmp/contrib_collectd2html.pl line 232.
Global symbol "$span" requires explicit package name at /tmp/contrib_collectd2html.pl line 237.
syntax error at /tmp/contrib_collectd2html.pl line 245, near "}"
More information about the collectd-changes
mailing list