[collectd-changes] collectd, the system statistics collection daemon: Changes to 'collectd-5.3'
Florian Forster
octo at verplant.org
Thu Feb 26 11:44:52 CET 2015
ChangeLog | 87 ++++++++++++++++++++++++++++++++
configure.in | 51 ++++++++++---------
contrib/redhat/collectd.spec | 43 +++++++++-------
src/Makefile.am | 3 +-
src/collectd-exec.pod | 10 ++--
src/collectd.conf.in | 2 +-
src/collectd.conf.pod | 67 +++++++++++++++++++++++-
src/cpu.c | 2 -
src/exec.c | 4 +-
src/filter_chain.c | 67 +++++++++++++++---------
src/ipmi.c | 2 +-
src/libcollectdclient/client.c | 1 +
src/libcollectdclient/network_buffer.c | 4 ++
src/libvirt.c | 6 +++
src/logfile.c | 6 ++-
src/network.c | 4 ++
src/plugin.c | 2 +-
src/pyvalues.c | 5 +-
src/snmp.c | 2 +
src/syslog.c | 4 ++
src/types_list.c | 2 +-
src/utils_cmd_flush.c | 15 +++---
src/utils_cmd_getval.c | 15 +++---
src/utils_cmd_listval.c | 15 +++---
src/utils_cmd_putnotif.c | 15 +++---
src/utils_cmd_putval.c | 15 +++---
src/write_graphite.c | 18 +++++--
src/write_http.c | 9 ++--
src/write_redis.c | 2 +-
29 files changed, 356 insertions(+), 122 deletions(-)
New commits:
commit d14f0e36ea1a33075470558827140d5237af7fdc
Author: Florian Forster <octo at collectd.org>
Date: Thu Feb 26 11:31:03 2015 +0100
Bump version to 5.3.2; Update ChangeLog.
commit 9db291395f84b74076de5c96aca00e07f9eef0ff
Author: Florian Forster <octo at collectd.org>
Date: Thu Feb 26 09:11:02 2015 +0100
collectd-exec(5): Clarify the format of the Time: header.
commit 3e1563f6d79416f095c6246518eebf4fecc4fe07
Author: Florian Forster <octo at collectd.org>
Date: Thu Feb 26 09:04:37 2015 +0100
Revert "Plugin exec: change notification time to integer."
This was working as intended.
This reverts commit 07e4683f7f985668641d79137b64d148bc18ba8a.
commit d1483d2e2a9116c233aeaceba99fa58a7e6bdc87
Merge: afdbcde 89b7a6d
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Tue Feb 24 07:43:22 2015 +0100
Merge branch 'collectd-4.10' into collectd-5.3
Conflicts:
src/collectd.conf.pod
commit afdbcde73c266ec4123e9018c5e325c4d324bfb1
Author: Jim Radford <radford at galvanix.com>
Date: Tue Sep 17 17:52:03 2013 +0000
perl plugin: plugins are linked with *_LIBADD and LIBS not *_LIBS and LIBS
Conflicts:
src/Makefile.am
commit 9613c69afd6e5e0fad34ef8bb64f06d7211f5caf
Author: Jim Radford <radford at galvanix.com>
Date: Wed Aug 7 13:21:08 2013 -0700
libperl's ldopts include libaries and therefore should go in LIBS not LDFLAGS
Without this configure fails compile its libperl test program because
-lperl comes before the test program on the compiler command line.
Conflicts:
src/Makefile.am
commit f42ef7629fd32a51a9e0a782eaadedf13958b4e6
Merge: 92d1a1f 2804653
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Feb 2 11:24:08 2015 +0100
Merge pull request #899 from mfournier/write_http-multiple-destionations
write_http: make callback names context-dependent
commit 92d1a1ffbef7f4251164d1d3b64832f1dd7c474a
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Wed Jan 28 15:06:28 2015 +0100
RPM specfile: doc clarification
commit 89b7a6dfb77e5529e5089bf6593ed9fd83202429
Author: Vincent Bernat <vincent at bernat.im>
Date: Fri Jan 23 18:55:04 2015 +0100
ipmi: use SIGIO instead of SIGUSR2 to avoid conflict with JVM
Java uses SIGUSR2 to suspend/resume threads. The OpenIPMI plugins also
need a signal to resume its event loop when setting a timer. They can't
both use the same signal. We ask OpenIPMI to use SIGIO instead.
This should fix #114.
commit 8fa66d76900da4206f9066737c974dcfd2bd2e34
Author: Micha Krause <micha at noris.net>
Date: Fri Jan 23 14:24:54 2015 +0100
added doc CollectStatistics to section rrdcached
Fixes #907
Conflicts:
src/collectd.conf.pod
commit 454587041ce66b416536b45aaa3b4aa956ba9554
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Fri Jan 23 15:01:52 2015 +0100
mysql: document defaults to boolean config options
commit 28046539df61bb5b29d5acf3d03d65312df0e1ee
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Sat Jan 17 16:10:46 2015 +0100
write_http: make callback names context-dependent
This allows multiple destinations to work again (fixes #821), using the
same logic as other write plugins.
The callback name would now be something like:
`write_http/http://example.com/endpoint`
which is not very nice.
The next step would be to change this plugin to use `<Node>` blocks
like many others, and pass the URL as a parameter inside each instance
block. So I see this patch as the minimum required to let 5.3 and 5.4
users use this plugin with multiple destinations.
commit a06c934c92e1936d39e94bdb2fa8c81aba6f86ed
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Fri Jan 16 17:57:00 2015 +0100
RPM specfile: misc improvements related to perl files
Avoids installing some files in two different packages & locations. Also
avoid unnecessary dependencies on -perl and -contrib packages.
Supersedes #896.
Thanks to @faxm0dem for helping work things out !
commit 443afcad2cbacaca9bb1fd7d9ea790cbeb6ff015
Merge: 7e86633 631874e
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Wed Jan 7 23:32:21 2015 +0100
Merge branch 'collectd-4.10' into collectd-5.3
commit 7e866336a157b26d608337464c387e9aa5494230
Author: Manuel Luis Sanmartin Rozada <manuel.luis at gmail.com>
Date: Mon Mar 31 21:08:05 2014 +0200
Fix check for htonll in configure.ac
commit 631874e4161f9ac8651158aa81f0e7f8aa896ed9
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Wed Dec 31 14:54:37 2014 +0100
types_list: fix carriage return sign
Many thanks to @NsLib for mentioning this !
commit ba55ad9ae41052b665d008f20f4b7076983446e2
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Tue Dec 23 12:59:44 2014 +0100
RPM specfile: avoid packaging some files twice
Fixes #874
commit 3acf4aaf170b6d9be4a4a6a1ba0719c3f9df4c68
Author: Yoga Ramalingam <yramalingam1 at bloomberg.net>
Date: Mon Dec 8 13:09:47 2014 -0500
configure: Fixed check for AM_PATH_LIBCCRYPT
commit b8f53c82e19189ab329bb694ecfdc98044316070
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Dec 15 16:10:41 2014 +0100
collectd.conf example: remove erroneous quotes
Thanks to @ymettier for pointing that out !
commit c1318b06b424523d3704fcdfd16d3adb25d17d18
Merge: e86ddf6 7d6d1fa
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Fri Dec 12 23:13:15 2014 +0100
Merge branch 'collectd-4.10' into collectd-5.3
Conflicts:
src/libvirt.c
commit 7d6d1fa5855f053f262410e2d42968afa4514990
Author: Ruben Kerkhof <ruben at rubenkerkhof.com>
Date: Tue Dec 9 17:06:43 2014 +0100
virt plugin: only gather stats for running domains
Conflicts:
src/libvirt.c
commit e86ddf6e071a6012d868202ba6aad12c056af533
Merge: b7addce 082c59b
Author: trenkel <github at semidefinite.de>
Date: Wed Dec 3 20:59:29 2014 +0100
Merge pull request #839 from yogeswaran/python
Fix Py list length check in cpy_build_meta()
commit 082c59b439105cc5c0b787346ac2bdb9ca10e5a6
Author: Yoga Ramalingam <yramalingam1 at bloomberg.net>
Date: Wed Dec 3 14:37:06 2014 -0500
Fixed indentation and decreased reference count
commit f0cb93348f16ee9bb3138d1ef977ebc796123c9d
Author: Yoga Ramalingam <yramalingam1 at bloomberg.net>
Date: Wed Dec 3 12:20:17 2014 -0500
Fix Py list length check in cpy_build_meta()
commit b7addce8b0293be5647fe4aa2e6545930a9beecb
Merge: 99953c7 ca450c5
Author: Pierre-Yves Ritschard <pyr at spootnik.org>
Date: Wed Dec 3 16:06:13 2014 +0100
Merge pull request #827 from yogeswaran/collectdctl
collectdctl command hangs on AIX and returns error 0 on Solaris.
commit ca450c5a11579d93326bc57e286b82db4b4c186c
Author: Yoga Ramalingam <yramalingam1 at bloomberg.net>
Date: Wed Dec 3 08:40:18 2014 -0500
Removed extra semicolon
commit 99953c794e42874ba91e29a97fcc525065d0a9c7
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Tue Dec 2 23:42:06 2014 +0100
RPM specfile: require package providing ltdl.h
commit 5416295cbf519eee82bfc96e4ffd503562ea1189
Author: Yoga Ramalingam <yramalingam1 at bloomberg.net>
Date: Mon Dec 1 09:55:10 2014 -0500
Wrap the content of macro with do/while to make it safer as per code review comment
commit 9f5ea03c55ef747c63a258e7abdbbf07a3b1bbf7
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Dec 1 09:07:30 2014 +0100
cpu: remove legacy assignment to undefiend variable
This finishes up the cleanup done by f7100301fa. It also fixes #828
(build error on Mac OS).
Many thanks to @njh for pointing that out !
commit 993900f43c19c3836a6a4e89268ffb6d17d0fce0
Author: Yoga Ramalingam <yramalingam1 at bloomberg.net>
Date: Wed Nov 12 16:07:15 2014 -0500
collectdctl command hangs on AIX and returns error 0 on Solaris.
Summary:
Problem: collectdctl command hangs on AIX and returns error 0 on Solaris.
Root cause - client (collectdctl) and server (collectd daemon) are using fprintf to communicate using Unix domain socket, Since fprintf buffers, command sent by client did not reach server, since client does not get the response, it closes the socket which forces the client to flush the command, now server receives the command, when responding, it gets socket error because the client already closed the socket.
Solution: Added flush after all fprintf calls.
Test Plan: Tested collectdctl on AIX and SunOS for listval, getval commands
Reviewers: skhajamo
Reviewed By: skhajamo
CC: arcyd
Differential Revision: https://all.phab.dev.bloomberg.com/D155584
commit 51a4e62d7d0e73d8d5822efaef1e3218b5ad0373
Merge: cfce0a6 dc0ae7a
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Nov 24 09:18:44 2014 +0100
Merge branch 'collectd-4.10' into collectd-5.3
commit cfce0a60ee7d57148067ef7ea600410e566bd322
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Wed Nov 19 17:49:30 2014 +0100
Revert "Let snmp_synch_response deal with PDU freeing"
This reverts commit e767dc103a142e1c57800f06a9c384f21a48aef5.
The proper fix to this issue is in the collectd-4.10 branch. See also
79e90bba.
commit dc0ae7a199e56255a1baf96ed4bd804b168daca7
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Wed Nov 19 17:54:09 2014 +0100
snmp: avoid freeing req under normal operation
Equivalent patch to 79e90bba5, to avoid issue #804 introduced while
fixing #610.
commit e767dc103a142e1c57800f06a9c384f21a48aef5
Author: Pierre-Yves Ritschard <pyr at spootnik.org>
Date: Wed Nov 19 16:00:54 2014 +0100
Let snmp_synch_response deal with PDU freeing
When reading from tables, upon errors the PDUs sent are already
freed by snmp_synch_response since they are right after
snmp_send is called.
This commit syncs collectd's approach with other occurences of
snmp_synch_response calls.
There might be a few corner cases where we leak PDUs, but it
is unclear how to check for those since we would need to
have an indication that snmp_send was never called, which
as far as I can tell is not possible.
The potential for failure in snmp_send is rather low and will
be easily spotted though, since when crafting invalid PDUs
snmp send will constantly fail and since valid configurations
can never leak memory.
This fixes #804
commit 3ebba024911f32c4b870937747be8e623439964d
Merge: 027148f 2a4a6a5
Author: Pierre-Yves Ritschard <pyr at spootnik.org>
Date: Sat Nov 15 15:45:00 2014 +0100
Merge pull request #796 from mfournier/write_redis-colon-mistake
write_redis: re-add colon dropped in b7984797 + manpage
commit 027148fd9f4a43673cd9729eebf38ec8b0075300
Author: Bjørn Nordbø <bjorn at wearezeta.com>
Date: Wed Nov 12 12:27:43 2014 +0100
Link aggregation.so to libm.so
Conflicts:
src/Makefile.am
commit 0e24ad12c7a741be3a6214d0712cad74c68d33f9
Merge: 7a36dbe de067db
Author: Pierre-Yves Ritschard <pyr at spootnik.org>
Date: Tue Nov 11 19:39:58 2014 +0100
Merge pull request #765 from tokkee/sh/write-err
Use the complain mechanism to report write failures.
commit 7a36dbe8c81a2d7ea9cb7cf8379aaa7049d58930
Author: Vincent Bernat <vincent at bernat.im>
Date: Fri Nov 7 15:20:22 2014 +0100
network: don't enable gcrypt thread callbacks when gcrypt recent enough
From `gcrypt.h`:
> NOTE: Since Libgcrypt 1.6 the thread callbacks are not anymore used.
> However we keep it to allow for some source code compatibility if used
> in the standard way.
Otherwise, we get a deprecation warning which is turned into an error:
```
CC libcollectdclient_la-network_buffer.lo
../../../src/libcollectdclient/network_buffer.c:58:15: error: 'gcry_thread_cbs' is deprecated (declared at /usr/include/gcrypt.h:213) [-Werror=deprecated-declarations]
GCRY_THREAD_OPTION_PTHREAD_IMPL;
```
Fixes: #632
commit 2a4a6a5203e4ed2188842eab171070e44a7fd2d9
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Tue Nov 11 11:39:40 2014 +0100
add write_redis to manpage
commit 6725a91fd6be18b6f3475fc0eeccfb6424a73f5c
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Sun Nov 9 00:16:11 2014 +0100
write_redis: re-add colon dropped in b7984797
When running f3706b0b87, the following command gets sent to redis:
"ZADD" "collectd/hostname/entropy/entropy" "1415487432.000000" "1415487432:932"
Meaning the value actually stored, and later returned by redis is:
"<timstamp>:<value>".
b7984797 accidentally dropped the comma separating the timestamp and the
value, which leads the plugin to store a somewhat confusing value in
redis:
"ZADD" "collectd/hostname/entropy/entropy" "1415487432.000000" "1415487432932"
commit 1bbb3846fb60e220721c7c29fb5ef214d99c2293
Merge: c86a35c f5d2a5e
Author: Pierre-Yves Ritschard <pyr at spootnik.org>
Date: Tue Nov 4 17:41:38 2014 +0100
Merge pull request #764 from tokkee/sh/collectd-5.3
write_graphite plugin: Improved error reporting when connecting to the server.
commit 432d7039dc3ad93ec938f4bff1036f899ef3bc63
Author: Katelyn Perry <katelyn at superleg.it>
Date: Mon Nov 3 17:11:14 2014 -0600
fix grammar in plugin loading error message
"cause for this problem are" => "cause for this problem is"
commit c86a35c78789d080cf376244c5e1fb62f4babe30
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Tue Jun 24 17:47:08 2014 +0200
logfile: avoid total silence in case of a misconfiguration
Basically the same patch that was applied to syslog.c in 84c38056
commit c76551aef20151a34a785f756a7dc359ba1b3865
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Tue Jun 24 17:48:26 2014 +0200
correct typo in error message
commit 84e796d11f9c588c0ce7fee5a2035bf3d4aca596
Author: Wilfried Goesgens <dothebart at citadel.org>
Date: Sat Jun 7 12:01:32 2014 +0200
Syslog: if we can't find the loglevel specified by the configuration string default to 'info' and warn about the unknown configuration option. no way to make syslog totaly silent anymore.
commit de067db48b0f16b6678a900339801c6cb59681a3
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Oct 19 20:25:50 2014 +0200
Use the complain mechanism to report write failures.
This ensures that we don't spam the log for each submitted value. Instead, an
exponential backup is used to report permanent errors starting at one message
per second.
commit f5d2a5e24045a0a145408b20d0a28557b4c9d3f5
Author: Sebastian Harl <sh at tokkee.org>
Date: Sun Oct 19 18:22:09 2014 +0200
write_graphite plugin: Improved error reporting when connecting to the server.
More information about the collectd-changes
mailing list