[collectd-changes] collectd, the system statistics collection daemon: Changes to 'collectd-5.2'

Florian Forster octo at verplant.org
Fri Jan 25 10:14:51 CET 2013


 src/postgresql.c |   44 ++++++++++++++++++++++++++++----------------
 1 file changed, 28 insertions(+), 16 deletions(-)

New commits:
commit 7bbba254348a7fa98c4337455a3e0eae88ce0e86
Author: Sebastian Harl <sh at tokkee.org>
Date:   Wed Jan 23 09:26:48 2013 +0100

    postgresql plugin: Don't access realloc'ed memory.
    
    D'oh! This is the most stupidest bug: all database connection objects are
    stored in a plugin-global array and a pointer to each object was passed around
    to the worker functions. This array used to be an array of objects (rather
    than pointers) and was realloc'ed every time a new connection was added. Now,
    the realloc caused the old pointer to not be valid any more, thus, any but the
    last database connection were later accessing memory out of range. This caused
    the plugin to segfault if more than one database connection was used.
    
    Thanks to Greg Swift for reporting this!
    Fixes Github issue #238.




More information about the collectd-changes mailing list