[collectd-changes] collectd, the system statistics collection daemon: Changes to 'ar/lpar'

[Florian Forster]

 src/lpar.c   |  302 ++++++++++++++++++++++++++++++++-------------------------
 src/types.db |    1 +
 2 files changed, 170 insertions(+), 133 deletions(-)

New commits:
commit 7134cf10f759b177fa0410dcc9caeaaf09dd0336
Author: Florian Forster <octo at leeloo.lan.home.verplant.org>
Date:   Sat Sep 11 11:04:44 2010 +0200

    lpar plugin: Introduce a "NS_TO_TICKS" macro.
    
    This makes the code easier to read, IMHO.

commit 75efef3359f6565c8833563414367b89fbeacc46
Author: Florian Forster <octo at leeloo.lan.home.verplant.org>
Date:   Sat Sep 11 11:04:04 2010 +0200

    lpar plugin: Move / add comments.

commit 3451d2486faf938b9e78dafcdf8c30ed375af19f
Author: Aurélien Reynaud <aurelien at wattapower.net>
Date:   Thu Sep 9 22:43:16 2010 +0200

    lpar plugin update
    
    Hello,
    
    here is a new patch against ar/lpar with the following features :
    
    - get back to the original implementation with gauges only. A new type
    "vcpu" is created (it was "lpar_pcpu" in the original)
    
    - I tried to keep as much as possible of your changes, but some have
    been reverted (the init function is back) because it was simpler for me
    to port my previous code rather than adapt it to the current form. Feel
    free to change them again
    
    - the "consumed" metric might seem superfluous at first sight as it
    could be calculated in the frontend in the general case. But I thought
    it might come in handy when dealing with dedicated partitions, where
    donated and stolen values are no easy concepts. Not everyone wants to
    dig into the code and the APIs to find out what they mean and whether
    they should be added to or substracted from other values...
    
    As a side note, one  of the changes you introduced was better checking
    of the return status from perfstat_partition_total() using errno. This
    reminded me that under AIX errno is by default unsafe to use in a
    multithreaded environment (which collectd is). I posted a fix ("Fix
    errno thread-safety under AIX") on Sat, 19 Jun 2010, which if I am not
    mistaken has not been merged yet.
    
    Best regards,
    
    Aurélien Reynaud
    
    Signed-off-by: Florian Forster <octo at huhu.verplant.org>