[collectd-changes] collectd, the system statistics collection daemon: Changes to 'master'

Florian Forster octo at verplant.org
Thu Sep 17 18:37:46 CEST 2009


 src/perl.c      |    5 ++++
 src/processes.c |   63 +++++++-----------------------------------------------
 2 files changed, 14 insertions(+), 54 deletions(-)

New commits:
commit beefe438cc1e7119e2ba448cb190ec9ffa0b8e9e
Merge: 111064d7154cd6a5a781fb9c13cd9829c95ec7d9 1ef654ef7d8225667666b206819d63689dd3b2e4
Author: Florian Forster <octo at leeloo.lan.home.verplant.org>
Date:   Thu Sep 17 18:34:19 2009 +0200

    Merge branch 'collectd-4.8'

commit 1ef654ef7d8225667666b206819d63689dd3b2e4
Merge: 9fcc56456620f6f5663e7b2ca2168d612dc6bd6c 0f7c2b6ac38ad09ac767fe745737035acc22906e
Author: Florian Forster <octo at leeloo.lan.home.verplant.org>
Date:   Thu Sep 17 18:33:53 2009 +0200

    Merge branch 'collectd-4.7' into collectd-4.8

commit 0f7c2b6ac38ad09ac767fe745737035acc22906e
Author: Florian Forster <octo at leeloo.lan.home.verplant.org>
Date:   Thu Sep 17 18:26:41 2009 +0200

    perl plugin: Declare the “environ” variable.

commit bb227c48e62e8f4adebd028293b3b85d1c7db244
Author: Florian Forster <octo at huhu.verplant.org>
Date:   Thu Sep 17 18:02:34 2009 +0200

    processes plugin: Case argument of “isdigit” to int.
    
    On some platforms passing a char there causes problems :/

commit c327b3ae6b19713a56631e81886988121d3eef93
Author: Andrés J. Díaz <ajdiaz at connectical.com>
Date:   Thu Sep 17 13:15:02 2009 +0200

    processes plugin: Remove unnecessary call of realloc(3).
    
    Hi Florian (et al)
    
    > you're right, the (re-)allocation of the memory can probably be avoided
    > if the function is turned into one with the following prototype:
    > -- 8< --
    >  static int *ps_read_tasks (int pid,
    >     unsigned long *ret_num_proc,
    >     unsigned long *ret_num_lwp);
    > -- >8 --
    
    Mmm, why not something like: "static int ps_read_task(pid)"?
    This returns the number of task for pid passed as argument.
    (AFAIK the function only return the number ot threads), why
    we need the ret_num_proc and the ret_num_lwp parameters?
    
    My proposal is attached (code is always cleaner than explanations :P)
    
    Regards,
      Andres
    
    Signed-off-by: Florian Forster <octo at huhu.verplant.org>




More information about the collectd-changes mailing list