[collectd-changes] collectd, the system statistics collection daemon: Changes to 'collectd-4.7'

[Florian Forster]

 src/processes.c |   63 +++++++-----------------------------------------------
 1 files changed, 9 insertions(+), 54 deletions(-)

New commits:
commit bb227c48e62e8f4adebd028293b3b85d1c7db244
Author: Florian Forster <octo at huhu.verplant.org>
Date:   Thu Sep 17 18:02:34 2009 +0200

    processes plugin: Case argument of “isdigit” to int.
    
    On some platforms passing a char there causes problems :/

commit c327b3ae6b19713a56631e81886988121d3eef93
Author: Andrés J. Díaz <ajdiaz at connectical.com>
Date:   Thu Sep 17 13:15:02 2009 +0200

    processes plugin: Remove unnecessary call of realloc(3).
    
    Hi Florian (et al)
    
    > you're right, the (re-)allocation of the memory can probably be avoided
    > if the function is turned into one with the following prototype:
    > -- 8< --
    > Â static int *ps_read_tasks (int pid,
    > Â  Â  unsigned long *ret_num_proc,
    > Â  Â  unsigned long *ret_num_lwp);
    > -- >8 --
    
    Mmm, why not something like: "static int ps_read_task(pid)"?
    This returns the number of task for pid passed as argument.
    (AFAIK the function only return the number ot threads), why
    we need the ret_num_proc and the ret_num_lwp parameters?
    
    My proposal is attached (code is always cleaner than explanations :P)
    
    Regards,
      Andres
    
    Signed-off-by: Florian Forster <octo at huhu.verplant.org>