[collectd-changes] collectd, the system statistics collection daemon: Changes to 'collectd-4.8'

[Florian Forster]

 src/owniptc/libiptc.c |    4 ++++
 src/processes.c       |    5 ++++-
 src/types.db          |    4 ++--
 src/unixsock.c        |   34 ++++++++++++++++++++++++----------
 4 files changed, 34 insertions(+), 13 deletions(-)

New commits:
commit 6c134837a38a566a6ad78225ef5e5c3cc9b7d832
Merge: d828ed0a50f5a094f9ea5a699e6b2bfd4acbce16 5b5fff5bbdc5515d7f4c2a01df47373f4ac44847
Author: Florian Forster <octo at leeloo.lan.home.verplant.org>
Date:   Thu Oct 1 21:33:37 2009 +0200

    Merge branch 'collectd-4.7' into collectd-4.8

commit d828ed0a50f5a094f9ea5a699e6b2bfd4acbce16
Author: Florian Forster <octo at leeloo.lan.home.verplant.org>
Date:   Thu Oct 1 21:30:53 2009 +0200

    src/types.db: Replace spaces with tabs.

commit 5b5fff5bbdc5515d7f4c2a01df47373f4ac44847
Author: Florian Forster <octo at huhu.verplant.org>
Date:   Wed Sep 30 22:49:16 2009 +0200

    unixsock plugin: Fix a (well hidden) race condition.
    
    Within the client handling thread, fdopen is called twice on the file
    descriptor passed to the thread. Later those file handles are closed like:
    
      fclose (fhin);
      fclose (fhout);
    
    This is a race condition, because the first call to fclose will close the file
    descriptor. The second call to fclose will try the same. Usually, it would fail
    silently and all is well. On a busy machine, however, another thread may just
    have opened a file or accepted a socket. In that case an arbitrary file
    descriptor is closed. If the file descriptor is opened yet again fast enough,
    data may even end up in a totally wrong location.
    
    As a work-around the file descriptor is not dup'ed so each fdopen operates on
    its own file descriptor. As an alternative the "r+" mode and a single file
    handle may be suitable, too.
    
    Many thanks to Sven Trenkel for pointing me into the right directioin :)

commit fdba679afa5681557916095e393adcbecacbdc61
Author: Florian Forster <octo at leeloo.lan.home.verplant.org>
Date:   Sat Sep 26 10:48:50 2009 +0200

    libiptc: Comment out two unused static functions.
    
    Thanks to Sven Trenkel for noticing.

commit e75f137bdc3f6a002a8b31d822f7732e191c0f2b
Author: Andrés J. Díaz <ajdiaz at connectical.com>
Date:   Sat Sep 19 08:45:49 2009 +0200

    processes plugin: Fix handling of Linux 2.4.
    
    Hi Florian et al
    
    Thanks for the reply, but we detect a minor bug in the previous patch
    due to kernel 2.4
    
    The correct patch is attached. The bug is related with kernels 2.4,
    where task/ directory do not exists and ps_read_task return -1, which is
    catched and raise an error (breaking the ps_read_process function), so a
    NaN is dispatched istead of values (number of process:1, number of
    threads :1).
    
    Sorry for the inconvenience :(
    
    Regards,
      Andres
    
    Signed-off-by: Florian Forster <octo at leeloo.lan.home.verplant.org>