[collectd-changes] collectd, the system statistics collection daemon: Changes to 'collectd-4.7'

Florian Forster octo at verplant.org
Thu May 28 12:19:48 CEST 2009


 src/java.c |   15 ++++++++++++---
 1 files changed, 12 insertions(+), 3 deletions(-)

New commits:
commit 2450298205d926c2679bd5fd2b25a614112436a0
Author: Florian Forster <octo at leeloo.lan.home.verplant.org>
Date:   Thu May 28 12:10:42 2009 +0200

    java plugin: Replace dots ('.') with slashes ('/') when loading a class.
    
    Thanks to Randy Rizun for pointing this out:
    
    Hi!
    
    just wanted to point out an issue in cjni_config_load_plugin
    
    the call to FindClass passes the "Name" verbatim from the LoadPlugin directive
    
    one might intuitively say LoadPlugin "com.foobar.Plugin"
    
    whereas FindClass wants to see it as "com/foobar/Plugin"
    
    so I guess either (a) document LoadPlugin to say to use slashes or (b)
    subst / for . in cjni_config_load_plugin or (c) something else?!?
    
    of course, everything works fine if my plugin is in the 'default' java
    package (i.e., no package name) =)
    
    either way, thanks a lot for the great work!!
    
    -Randy

commit 9ae4ff9053e3ae8923db028b75669fcda19eb4ae
Author: Randy Rizun <rrizun at gmail.com>
Date:   Thu May 28 12:06:37 2009 +0200

    java plugin: Use slashes rather than dots to lookup classes.
    
    there are three (3) invocations of FindClass that use "." periods
    instead of "/" slashes
    
    java.lang.Long
    java.lang.Double
    org.collectd.api.DataSet
    
    those need to be fixed up to use "/" slashes
    
    Thanks!




More information about the collectd-changes mailing list