[collectd-changes] collectd, the system statistics collection daemon: Changes to 'collectd-4.7'

Florian Forster octo at verplant.org
Sat May 2 09:45:33 CEST 2009


 AUTHORS        |    4 +
 src/iptables.c |  181 ++++++++++++++++++++++++++++++++++++++++++++++++++-----
 2 files changed, 168 insertions(+), 17 deletions(-)

New commits:
commit 5e4d4e8d089e2b40c8f6eeee539519295e3f70e4
Author: Florian Forster <octo at leeloo.lan.home.verplant.org>
Date:   Sat May 2 09:39:08 2009 +0200

    AUTHORS: Added Marco.

commit 52b47d4c2fcb6cc5226ed9b4f6a0720c1bb4b3d1
Author: Florian Forster <octo at leeloo.lan.home.verplant.org>
Date:   Sat May 2 09:37:20 2009 +0200

    iptables plugin: Use the same enum everywhere.

commit 6a15196163ed05f9f8541962ef8782e5e22e1009
Author: Marco Chiappero <marco at absence.it>
Date:   Fri May 1 17:22:52 2009 +0200

    iptables plugin: Add support for ip6tables.
    
    Here is a stub but I have some trouble in making it work with "Chain6"
    rules, maybe I don't know exactely how to deal with configuration keys.
    I get "collectd[4887]: Plugin `iptables' did not register for value
    `Chain6'". Is there something I'm forgetting?
    
    There is another issue, the naming shema. I temporally changed the ipv6
    vl.plugin to "ip6tables" in the meantime. Options are:
    - different vl.plugin if possible (backward compatible)
    - new vl.plugin_instance name schema with ip protocol (not backward
      compatible)
    - new vl.type "ip6t_packets" and "ip6t_bytes" (backward compatible but
      taints the types.db with useless data)
    
    A note about the code: I created two different submit_chain and
    submit_match because using void pointers (and casting them afterwards)
    in a single function it's a little bit obscure and complicated with no
    real advantage. Sorry for some code duplication but in my opinion this
    is smartest way.
    
    Let me know your opinion, thank you.
    
    Regards,
    Marco
    
    Signed-off-by: Florian Forster <octo at leeloo.lan.home.verplant.org>




More information about the collectd-changes mailing list