[collectd-changes] collectd, the system statistics collection daemon: Changes to 'master'

Florian Forster octo at verplant.org
Thu Mar 19 14:21:47 CET 2009

 configure.in         |   10 +++
 src/Makefile.am      |   13 +++
 src/collectd.conf.in |    1 +
 src/types.db         |    1 +
 src/uptime.c         |  218 ++++++++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 243 insertions(+), 0 deletions(-)

New commits:
commit ec7ae67adc5ef53b67f2b0f91f12f4bc58a799b6
Author: Florian Forster <octo at huhu.verplant.org>
Date:   Thu Mar 19 14:21:16 2009 +0100

    uptime plugin: Shuffle some preprocessor stuff around.
    Fix some comments and possibly a Solaris bug, too.

commit d0da1c4e0cb3afe14eda9d24499f7c8bd1692286
Author: Florian Forster <octo at huhu.verplant.org>
Date:   Thu Mar 19 13:51:50 2009 +0100

    build system: Add the new `uptime' plugin.

commit 0c3fcab4abed820084393e64dc30a88512941de1
Author: Marco Chiappero <marco at absence.it>
Date:   Thu Mar 19 13:30:32 2009 +0100

    uptime plugin: Add a plugin to measure the time a system has been running.
    Florian Forster ha scritto:
    >Hi Marco,
    Hi Florian,
    > Checking the KSTAT_TYPE_NAMED twice (three times if you count the
    > assertion) is of course not necessary. I suspect a copy'n'paste error ;)
    Me too. Please remove the second one at least, kstat_read do not change
    >A quick `grep' revealed that `get_kstat' is only used in two places, the
    >memory and the swap plugin - both trying to figure out the pagesize. If
    >you need something else than `KSTAT_TYPE_NAMED', I'd suggest to move the
    >checks to a new function `get_kstat_pagesize' and use that function in
    >the two plugins.
    I went for the kstat.h only solution.
    Ok, I'm attaching the code, please check the preprocessor directives for
    the includes section, I don't much about defines created by the build
    system and its names.
    I'm using it right now on a linux machine, but I haven't tested yet on
    Solaris and BSDs. Today I tried to compile it on OpenSolaris, but after
    fighting with the packaging system and many other things I gave up and
    decided I won't try anymore. So, since I'd like to say the plugin is
    done after testing it, Solaris testers are wanted :P
    As soon as I can I will edit the wiki page, but first I want to have a
    closer look to the iptable plugin and see how many modifications are
    needed for IPv6 and then have an opinion about the single vs. double
    plugin approach.
    See you soon :)

More information about the collectd-changes mailing list