<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">19.07.2019 20:14, Sebastian Harl пишет:<br>
</div>
<blockquote type="cite"
cite="mid:20190719131408.GA128112@google.com"><br>
<pre class="moz-quote-pre" wrap="">What do you think is missing to make this a more compelling and
impactful proposal rather than just a "patch"?
</pre>
</blockquote>
<p>Case 1:<br>
I found a bug in 'virt' plugin, <a
href="https://github.com/collectd/collectd/issues/3009">https://github.com/collectd/collectd/issues/3009</a></p>
<p>You try to implement feature named "code owner".<br>
As per 'CODEOWNERS' file, @anaudx and @rjablonx are responsible
persons about 'virt' plugin.<br>
<span class="tlid-translation translation" lang="en"><span
title="" class="">As codeowners, they must solve the problem?
Or not? How much time do they have?<br>
</span></span><span class="tlid-translation translation"
lang="en"><span title="" class="">What is the penalty for
breaking the deadlines?</span></span><br>
<span class="tlid-translation translation" lang="en"><span
title="" class=""></span></span></p>
<p><span class="tlid-translation translation" lang="en"><span
title="" class="">Case 2:</span></span></p>
<p><span class="tlid-translation translation" lang="en"><span
title="" class=""><a
href="https://github.com/collectd/collectd/pull/2891">https://github.com/collectd/collectd/pull/2891</a><br>
</span></span></p>
<p>Some guys wrote their code and publish PR.<br>
You try to implement feature named "code owner".<br>
With new 'CODEOWNERS' policy, they could merge it w/o outside
review.<br>
</p>
<p>Please look, how much code was revorked after my review.<br>
Unfortunately, IIRC, not all nits was fixed.<br>
</p>
<p>Do you really think you will get better code when these guys will
simply merge code w/o any outside review?<br>
</p>
<p><span class="tlid-translation translation" lang="en"><span
title="" class="">Case 3:<br>
</span></span></p>
<p><span class="tlid-translation translation" lang="en"><span
title="" class="">Maintainer merged #3072 . This action breaks
CI in master branch.</span></span></p>
<p><span class="tlid-translation translation" lang="en"><span
title="" class="">Who is responsible on recovering CI checks
on master branch?<br>
</span></span><span class="tlid-translation translation"
lang="en"><span title="" class=""><span class="tlid-translation
translation" lang="en"><span title="" class="">What actions
should be taken and by whom?</span></span></span></span></p>
<p><span class="tlid-translation translation" lang="en"><span
title="" class=""><span class="tlid-translation translation"
lang="en"><span title="" class="">Case 4:<br>
<br>
CI checks continuously fails on clang-format.<br>
For some unknown reason, rules of checking was changed and
previously-formatted files needs to be reformatted again.</span></span></span></span></p>
<p><span class="tlid-translation translation" lang="en"><span
title="" class=""><span class="tlid-translation translation"
lang="en"><span title="" class=""><span
class="tlid-translation translation" lang="en"><span
title="" class="">Who is responsible on resolving this
clang-format check bug?<br>
Don't say me "code needs to be re-formatted again",
that is wrong.<br>
</span></span></span></span></span></span></p>
<p><span class="tlid-translation translation" lang="en"><span
title="" class=""><span class="tlid-translation translation"
lang="en"><span title="" class="">Case 5:</span></span></span></span></p>
<p><span class="tlid-translation translation" lang="en"><span
title="" class=""><span class="tlid-translation translation"
lang="en"><span title="" class="">CI checks continuously
hangs.</span></span></span></span></p>
<p>Latest example <span class="tlid-translation translation"
lang="en"><span title="" class=""><span class="tlid-translation
translation" lang="en"><span title="" class=""><a
href="https://github.com/collectd/collectd/pull/3207">https://github.com/collectd/collectd/pull/3207</a>
with developer comment.</span></span></span></span></p>
<p><span class="tlid-translation translation" lang="en"><span
title="" class=""><span class="tlid-translation translation"
lang="en"><span title="" class=""><span
class="tlid-translation translation" lang="en"><span
title="" class=""><span class="tlid-translation
translation" lang="en"><span title="" class="">Who
is responsible on resolving this issue?</span></span></span></span></span></span></span></span></p>
<p><span class="tlid-translation translation" lang="en"><span
title="" class=""><span class="tlid-translation translation"
lang="en"><span title="" class=""><span
class="tlid-translation translation" lang="en"><span
title="" class=""><span class="tlid-translation
translation" lang="en"><span title="" class="">-----<br>
</span></span></span></span></span></span></span></span></p>
<p>But you, of course, can continue work on your comfortable
Google-Docs documents instead of returning to earth.<span
class="tlid-translation translation" lang="en"><span title=""
class=""><br>
</span></span></p>
</body>
</html>