Hi,<div>so... what do you think of this ?</div><div><br></div><div><br></div><div>Julien Ammous<br><br><div class="gmail_quote">On 5 December 2010 18:12, Schmurfy <span dir="ltr"><<a href="mailto:schmurfy@gmail.com">schmurfy@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi,<div>I added a form of alternative to the filters which should do the job for me. I added a new hooks for plugins, they can register/unregister filter callbacks, the way they work is dead simple:</div>
<div>The callback method receives a copy of the value_list structure and is free to change whatever is inside (a safer version should prevent any changes to the length of values and values_len, currently I did the check in the lua plugin).</div>
<div><br></div><div>So what do you think of this solution ?</div><div>For me I can easily see it replace the curent filter system, here is a concrete example:</div><div><br></div><div><div>function cb_filter(vl)</div><div>
if vl.plugin == "something"</div><div> vl.plugin = "something_else"</div><div> end</div><div> </div><div> return vl</div><div>end</div></div><div><br></div><div>this would rename everything from plugin "something" to come from the plugin "something_else".</div>
<div>The code is pushed on my lua branch and is working.</div><div><br></div><div><br></div><div>For the callbacks dilemma I still have (you did not answer my last questions on it ;) ), I have another option for you between yours and mine: Allow the lua scripts to define ONE and only one callback for each type (collectd_register_read would becomes collected_set_read_callback).</div>
<div>Unless proved wrong I am convinced that providing more than one callback for each script is useless and makes the plugin code far more complex than it could, ever more since the language we call the function in is well able to handle a dispatcher easier than the C code if the user really wants it.</div>
<div><br></div><div>Julien Ammous.</div><div><br><div class="gmail_quote"><div><div></div><div class="h5">On 5 December 2010 08:51, Florian Forster <span dir="ltr"><<a href="mailto:octo@collectd.org" target="_blank">octo@collectd.org</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div></div><div class="h5">Hi Schmurfy,<br>
<div><br>
On Sun, Nov 28, 2010 at 04:30:10PM +0100, Schmurfy wrote:<br>
</div><div>> $PKG_CONFIG --exists lua5.1 2>/dev/null<br>
> becomes<br>
> $PKG_CONFIG --exists "lua >= 5.1" 2>/dev/null<br>
<br>
</div>I've fixed this in my "ja/lua" branch. The name used by pkg-config is<br>
not determined fully automatically, but you can specify it manually by<br>
using the following form:<br>
<br>
$ ./configure [$OTHER_OPTIONS] LIBLUA_PKG_CONFIG_NAME="lua"<br>
<br>
Regards,<br>
<div><div></div><div>—octo<br>
--<br>
Florian octo Forster<br>
Hacker in training<br>
GnuPG: 0x0C705A15<br>
<a href="http://octo.it/" target="_blank">http://octo.it/</a><br>
</div></div><br></div></div><div class="im">-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.9 (GNU/Linux)<br>
<br></div>
iQIcBAEBAgAGBQJM+0SQAAoJEMPSHpbi2MmgWYIQAJKgSkSCumWCaM/FaisPO6gZ<br>
5uQKXd5+aoWUONyP4eh9LBZXY3ExTpSHJakCnVPpdrFDiKG7dUTwgIksVP1TCqbz<br>
gSzWJ4NDBRUoYG6ahaynvAAnewFjkfb3SSygeNVz1wZl2EEqN1SozEV2t0ahDBcO<br>
hoAduMF9XDbkPyBPLArWN5o10JPn/sG0kmUKZ6nMUWrLtBXiJkElF78QvfI7a7ZZ<br>
P1y1+K9hTXM5G5jWyvsP2aAgA3/ceyiEsrS9dLUZ20QeuiVeV/pTmoH4aI0rSRKJ<br>
MfbEIsnqJnZkqyLd63r79hKFwrl63G5j+T+eKAM4eCKiuNfBZLmcD8xiVQRNCmoc<br>
iFPBbfsN+e+bG4QnRG7DXW23Z1ZGiIkkNpTkU6rhjE/eH3Tiz8n2PsSwfo/cEvem<br>
wZOv8DAoZY4c7fYO3Er35vMnU0Am7RB+6cFc+JCJL8t2wjmLOjAUGKTKaTigaX2u<br>
PK6lp6PAFLBLpAeJwhZBRc0kNaTEtim24oFHcbpU9HBVca9u2YaRvoylSFJfhO49<br>
oDLv5llYLrq+s3hX440EOh7b5okj6lSKUWTrcuwOekE0vfwYHBLkasc9Cs44JYTy<br>
ok8aKk7MFEJr7FgCGxzFauP/NK0w6h9fJSHuI7r57GTGGT9oPCFus/vjBAvK/0Nu<br>
H9Z+Qz12Je5jxNFta8ud<br>
=LzTj<br>
-----END PGP SIGNATURE-----<br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>