It is not improvements to do plugin that you did, it is more that you wrote half of the plugin ;)<div>I already did most of the work you surely had to do to write this, I just wanted to have a build system running before adding more code to the plugin.</div>
<div><br></div><div>For the read/write callbacks we can call a function by name from the C code which is enough in my opinion and should reduce the C code of the plugin, with one function called you can call as many as you want in the lua code itself as you wish.<br>
<br><div class="gmail_quote">On 24 November 2010 18:07, Florian Forster <span dir="ltr"><<a href="mailto:octo@collectd.org">octo@collectd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi,<br>
<div class="im"><br>
On Tue, Nov 23, 2010 at 10:20:10PM +0100, Florian Forster wrote:<br>
> no problem ;) While I still don't particularly *like* autoconf, I at<br>
> least learned to work with it. I'll look into it as soon as I find<br>
> some time for it.<br>
<br>
</div>I've done some improvements to the build system and the plugin itself. I<br>
rebased the commits to the current master branch, so you probably have<br>
to (re)set your branch to there instead of merging the changes.<br>
<br>
I didn't take a close look yet, but it appears the build scripts have<br>
changed between Lua 5.0 and 5.1 – from a custom build script to a<br>
pkg-config file. I'll try to incorporate this eventually.<br>
<br>
Unfortunately I don't have time to explain my changes in detail, I hope<br>
you'll figure out what I did. As always, I tried to keep the code as<br>
self-explanatory as possible, but this stack based VM doesn't exactly<br>
make this easy :/<br>
<div><div></div><div class="h5"><br>
Best regards,<br>
—octo<br>
--<br>
Florian octo Forster<br>
Hacker in training<br>
GnuPG: 0x0C705A15<br>
<a href="http://octo.it/" target="_blank">http://octo.it/</a><br>
</div></div><br>-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.9 (GNU/Linux)<br>
<br>
iQIcBAEBAgAGBQJM7UY+AAoJEMPSHpbi2Mmg1FwP+wVIw5wqJn8AxyM6jwBarOEg<br>
apdPh0R1wSUvZh+ur+ZWTClewH166hGR/QM5Ib+8oD/XGGBKIL3HowlmKB51nV9o<br>
uaWjJ/wEUn6nUjAxrXUsdFotCLiaqmFYi+aszDUrDaZqoIhbmJAwP7B7F6YD/UgE<br>
2Miwkh6PyPXM0Rmup5+X1OpTm12JmzYOXC3Tgg/mtEP4UDp15hoasVMIMwdOrBG7<br>
LHKw1G8svy/bDSi2nbc+8I3eJC7EdOHo0DR4pOszBdJHXOpjqRFoGRkVq+sxkbSG<br>
FfN0KXhvPBWHYLyFgWDx1CY0IsRu8YbiD7yIyTSabq38d3gZh4cAvYkb24kqmiIr<br>
xK/BJ8dtopFIJvK7adOuGFG6RsKIbNe0Grq6iLvHA0+rNQeUAa1h1O5Dp23sLoE/<br>
plrQv1cqq+SnBCSpzLJkE1osq6DqsSjqIyQECuXSsP1PoWtHPZDRfxZmFKBUl9hA<br>
/dSaCbGNl9S8MwKdMdLmPsAIp1dPTmbmmAYoPWuaK+syxjFWlJL5FZZ4h1x4Vx4x<br>
0+CbYhNd2mnB1d+Ng9WpIpjYvQ4fsx6nSucT9auIdP8GHL4hwBNcXBV7d+SNfBeb<br>
l5ZEHUX8xBdq5cAokZdBNJeSKuAQZX9EIGZPICvqv25K72XcjptYabyubYaiL9lD<br>
XiCzqSVeInCxwsYOV9Y+<br>
=NKVl<br>
-----END PGP SIGNATURE-----<br>
<br></blockquote></div><br></div>