<br>On Wed, Feb 10, 2010 at 7:04 PM, Florian Forster <span dir="ltr"><<a href="mailto:octo@verplant.org">octo@verplant.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi Amit,<br>
<div class="im"><br>
On Wed, Feb 10, 2010 at 05:13:22PM +0530, Amit Gupta wrote:<br>
</div><div class="im">> There seems to be two issues:<br>
> - s_addr member already exists in netinet/in.h on Solaris/OpenSolaris<br>
> and thus changing the variable name in utils_dns.c will fix this<br>
> issue.<br>
<br>
</div>> - struct in6_addr s_addr;<br>
> + struct in6_addr saddr;<br>
> struct in6_addr d_addr;<br>
<br>
okay. Could you rename "s_addr" to "src_addr" and "d_addr" to "dst_addr"<br>
then?<br></blockquote><div>Will do that. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im"><br>
> - struct ip6_ext is defined in netinet/ip_compat.h for Solaris<br>
> 10/OpenSolaris and thus needs to be included in utils_dns.c.<br>
<br>
</div>> +#define SOLARIS2 10<br>
<br>
What does this define do? Can you document that in the code so the<br>
casual reader knows what's going on?<br></blockquote><div>This is needed by ip_compat.h on solaris to include the right structures and include files for a particular version of solaris. I am thinking of moving this define to the <a href="http://config.h.in">config.h.in</a> and its value will be the solaris version (extracted from $host_os)<br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
> +#include <netinet/ip_compat.h><br>
<br>
That file isn't available under Debian Linux. Could you find out if<br>
that file needs to be included before / after some other file (there are<br>
such limitations under BSD for other netinet/*.h files) and add an<br>
appropriate check to the configure script?<br></blockquote><div>I am not sure about this. I will try to figure out. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
> # include <netinet/in_systm.h><br>
<br>
It's probably a good idea to base the check for <netinet/ip_compat.h> on<br>
the check for <netinet/in_systm.h>.<br></blockquote><div>Does including the ip_compat.h under "#if KERNEL_SOLARIS" makes sense given that this is a solaris specific fix?<br><br>Regards<br>Amit<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Regards,<br>
—octo<br>
<font color="#888888">--<br>
</font><div><div></div><div class="h5">Florian octo Forster<br>
Hacker in training<br>
GnuPG: 0x91523C3D<br>
<a href="http://verplant.org/" target="_blank">http://verplant.org/</a><br>
</div></div><br>-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.6 (GNU/Linux)<br>
<br>
iD8DBQFLcrYDHdggu3Q05IYRAkJkAJ9LszoIK6RyRJU/WT3Tfk9s2Vl8tQCfT9EG<br>
zIsbFjT5pjrqTdArnxJK6Tk=<br>
=VPQq<br>
-----END PGP SIGNATURE-----<br>
<br></blockquote></div><br>