<br><br><div class="gmail_quote">On Wed, Feb 10, 2010 at 6:46 PM, Florian Forster <span dir="ltr"><<a href="mailto:octo@verplant.org">octo@verplant.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi Amit,<br>
<div class="im"><br>
On Thu, Jan 28, 2010 at 02:03:53PM +0530, Amit Gupta wrote:<br>
> Today, I downloaded collectd-4.9.0 source code. However, I couldn't<br>
> see the jar patch applied as yet. Here is the updated patch with<br>
> respect to 4.9.0 source code.<br>
<br>
</div>sorry, I lost track :/ In general your patch looks fine, thank you very<br>
much :)<br>
<br>
> + mkdir -p .libs<br>
> + mkdir -p "$(DESTDIR)$(pkgdatadir)/java"<br>
> + $(JAR) cf .libs/java-plugin.jar "org/collectd/api"/*.class<br>
> + $(JAR) cf .libs/jmx.jar "org/collectd/java"/*.class<br>
> + $(INSTALL) -m 644 .libs/java-plugin.jar \<br>
> + "$(DESTDIR)$(pkgdatadir)/java"<br>
> + $(INSTALL) -m 644 .libs/jmx.jar \<br>
> + "$(DESTDIR)$(pkgdatadir)/java"<br>
<br>
I'm not that happy about the .jar filenames. I propose to use<br>
"collectd-api.jar" and "generic-jmx.jar". Do you see any problems with<br>
that?<br></blockquote><div> </div><div>I am okay with these names as well. Do you want me to submit a updated patch?<br><br>Regards<br>Amit<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="h5"><br>
Regards,<br>
—octo<br>
--<br>
Florian octo Forster<br>
Hacker in training<br>
GnuPG: 0x91523C3D<br>
<a href="http://verplant.org/" target="_blank">http://verplant.org/</a><br>
</div></div><br>-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.6 (GNU/Linux)<br>
<br>
iD8DBQFLcrHIHdggu3Q05IYRAp1FAJ9Th4qw+IdF+WT6ZqQfn6sraJcWmACfdkLw<br>
/PxJ26Ygfhy4OS9kT9D4o28=<br>
=lRS6<br>
-----END PGP SIGNATURE-----<br>
<br></blockquote></div><br>