Here is the updated patch.<br><br>On Mon, Sep 14, 2009 at 7:19 PM, Sebastian Harl <span dir="ltr"><<a href="mailto:sh@tokkee.org">sh@tokkee.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi Amit,<br>
<div class="im"><br>
On Mon, Sep 14, 2009 at 07:02:20PM +0530, Amit Gupta wrote:<br>
> Do find the patch attached. I have also got the jmx java classes to be<br>
> compiled (as a part of build process) in this patch. Let me know if the<br>
> patch looks okay.<br>
<br>
</div>The patch looks mostly fine to me. See two small comments / nitpicks<br>
below.<br>
<br>
> diff --git a/bindings/java/Makefile.am b/bindings/java/Makefile.am<br>
> index af5e480..0d9ee74 100644<br>
> --- a/bindings/java/Makefile.am<br>
> +++ b/bindings/java/Makefile.am<br>
[…]<br>
> +install-exec-local: java-build-stamp jmx-build-stamp<br>
> + mkdir -p "$(DESTDIR)$(pkgdatadir)/java"<br>
> + $(JAR) cf java-plugin.jar "org/collectd/api"/*.class<br>
> + $(JAR) cf jmx.jar "org/collectd/java"/*.class<br>
> + $(INSTALL) -m 644 java-plugin.jar \<br>
> + "$(DESTDIR)$(pkgdatadir)/java"<br>
> + $(INSTALL) -m 644 jmx.jar \<br>
> + "$(DESTDIR)$(pkgdatadir)/java"<br>
<br>
What do you think about creating the jar files in .libs/ or something?<br>
That would avoid problems with locally modified versions …<br></blockquote><div><br>ok. I now create a .libs dir right in the bindings/java during the install.<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
> clean-local:<br>
[…]<br>
> + rm -f *.jar<br></blockquote><div><br>Make sense. I now delete the .libs dir containng the jars during clean. <br><br>Regards<br>Amit<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Removing all jar files in the top level java directory does not sound<br>
like a good idea to me. Developers might have other jar files around for<br>
testing purposes or whatever. Unconditionally removing some directory<br>
.libs/ would be fine for me though.<br>
<br>
Hope you'll forgive my nitpickyness ;-)<br></blockquote><div> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Cheers,<br>
Sebastian<br>
<font color="#888888"><br>
--<br>
</font><div><div></div><div class="h5">Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ <a href="http://tokkee.org/" target="_blank">http://tokkee.org/</a><br>
<br>
Those who would give up Essential Liberty to purchase a little Temporary<br>
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin<br>
<br>
</div></div><br>-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.9 (GNU/Linux)<br>
<br>
iEYEARECAAYFAkquSgMACgkQEFEKc4UBx/xqkACePMpSkHWdgzSBqpfT5qP7yAPH<br>
T䀊ࠝﴃ攲鳣龞ꄬ딤�<br>
=rbmf<br>
-----END PGP SIGNATURE-----<br>
<br></blockquote></div><br>